Date: Wed, 01 Aug 2001 10:43:00 -0700 From: Dima Dorfman <dima@unixfreak.org> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.sys.mk Makefile bsd.kmod.mk bsd.lib.mk bsd.prog.mk Message-ID: <20010801174305.7C9C93E31@bazooka.unixfreak.org> In-Reply-To: <200108011714.f71HERW04580@freefall.freebsd.org>; from obrien@FreeBSD.org on "Wed, 1 Aug 2001 10:14:27 -0700 (PDT)"
next in thread | previous in thread | raw e-mail | index | archive | help
"David E. O'Brien" <obrien@FreeBSD.org> writes: > obrien 2001/08/01 10:14:27 PDT > > Modified files: (Branch: RELENG_4) > share/mk Makefile bsd.kmod.mk bsd.lib.mk > bsd.prog.mk > Added files: (Branch: RELENG_4) > share/mk bsd.sys.mk > Log: > MFC: The WARNS framework. > This is good stuff, and RELENG_4 deserves to have this. Although I'm happy to see that this will be in 4.4, I think you should've discussed it with Kris. First, he planned on setting NO_WERROR on by default so that -stable isn't broken so much[1] (which I think you haven't done)[2], and you haven't MFC'd rev. 1.4 of src/contrib/gcc.295/c-decl.c, which will ensure that the -stable build is broken. [1] The idea is that committers would be able to check for and fix warnings, but Joe Users wouldn't be disappointed with more breakage than necessay. [2] I didn't look very carefully, but you didn't mention that part in your commit log, so I assume you didn't do it. If this isn't the case, please accept my apologies. Other than those gripes, thanks for doing the sweeps. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010801174305.7C9C93E31>