From owner-cvs-all Tue Jan 21 12:54:24 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 531DD37B401; Tue, 21 Jan 2003 12:54:23 -0800 (PST) Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id B721A43EB2; Tue, 21 Jan 2003 12:54:22 -0800 (PST) (envelope-from gibbs@scsiguy.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6+Sun/8.11.6) with ESMTP id h0LKsFh00656; Tue, 21 Jan 2003 12:54:15 -0800 (PST) Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id MAA19555; Tue, 21 Jan 2003 12:54:09 -0800 (PST) Received: from [10.100.253.70] (aslan [10.100.253.70]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id NAA21408; Tue, 21 Jan 2003 13:54:06 -0700 (MST) Date: Tue, 21 Jan 2003 13:54:07 -0700 From: "Justin T. Gibbs" Reply-To: "Justin T. Gibbs" To: Sam Leffler , Thomas Moestl , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sparc64/sparc64 iommu.c Message-ID: <143002704.1043182447@aslan.btc.adaptec.com> In-Reply-To: <04bf01c2c178$4cc3eca0$52557f42@errno.com> References: <200301211708.h0LH8Mn5005942@repoman.freebsd.org> <04bf01c2c178$4cc3eca0$52557f42@errno.com> X-Mailer: Mulberry/3.0.0b10 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >> tmm 2003/01/21 09:08:22 PST >> >> Modified files: >> sys/sparc64/sparc64 iommu.c >> Log: >> Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_* >> constants where flag bits (as in NetBSD), although they are > consecutively >> numbered in FreeBSD. This would cause unnecessary flushing in the >> BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless. >> >> Revision Changes Path >> 1.16 +13 -5 src/sys/sparc64/sparc64/iommu.c >> > http://cvsweb.FreeBSD.org/src/sys/sparc64/sparc64/iommu.c.diff?r1=1.15&r2=1. > 16 >> > > Gack! Do you see a good reason for this? This seems like something that'll > cause really hard to find bugs when porting drivers (though one should > probably not use more than one flag per op). I'd really like to see these > constants have the same value on all systems. > > Sam Its a bug that they are not defined as flags. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message