From owner-svn-ports-head@FreeBSD.ORG Tue Sep 16 17:31:22 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 014A5900; Tue, 16 Sep 2014 17:31:21 +0000 (UTC) Received: from forward2l.mail.yandex.net (forward2l.mail.yandex.net [IPv6:2a02:6b8:0:1819::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Certum Level IV CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87C58FA3; Tue, 16 Sep 2014 17:31:21 +0000 (UTC) Received: from smtp3h.mail.yandex.net (smtp3h.mail.yandex.net [84.201.186.20]) by forward2l.mail.yandex.net (Yandex) with ESMTP id 6BC6F1AC0F95; Tue, 16 Sep 2014 21:31:17 +0400 (MSK) Received: from smtp3h.mail.yandex.net (localhost [127.0.0.1]) by smtp3h.mail.yandex.net (Yandex) with ESMTP id 43A9E1B44D22; Tue, 16 Sep 2014 21:31:16 +0400 (MSK) Received: from unknown (unknown [178.76.214.146]) by smtp3h.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id JH1PRRJRds-VFaGEL3I; Tue, 16 Sep 2014 21:31:15 +0400 (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (Client certificate not present) X-Yandex-Uniq: 120081ff-8ec5-4b0e-8987-6a0c1019c5da DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1410888675; bh=FEc6Kw12Aw4dteZGQrokI8eKbdcZZ9tmkjFHdJ3pOHg=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=WLs3MRSc7halE8J3tQsjPeZUK+AKUfRS0EG43kMqd8LYZJSVlGoTDyyfgMm2j9iPl NLHZexKoGz8vTH0QDlbHgAWKOXD5d7QEJMl3rDTKtYPQCNiqT1SldJMTSukQBNEKJd ACZFDQQ3LNiOXLSDEUuUaZ7UVa69MuCHwvfzeJkU= Authentication-Results: smtp3h.mail.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <541873CA.60909@yandex.ru> Date: Tue, 16 Sep 2014 21:30:50 +0400 From: Ruslan Makhmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: "Jason E. Hale" , Adam Weinberger Subject: Re: svn commit: r368241 - in head/sysutils: . jadm jadm/files References: <201409150227.s8F2ReuH083121@svn.freebsd.org> <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , ports-committers , jadm , "Vanilla I. Shu" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Sep 2014 17:31:22 -0000 Jason E. Hale wrote on 15.09.2014 20:05: > On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger wrote: >> On 15 Sep, 2014, at 3:50, Jason E. Hale wrote: >> >>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu wrote: >>>> >>>> +BUILD_DEPENDS= ${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko \ >>>> + ${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces \ >>>> + ${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate \ >>>> + ${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress >>> >>> This is a deprecated style of depending on other Python ports. >>> Format should be: >>> BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}paramiko>=0:${PORTSDIR}/security/py-paramiko >> >> I had no idea that format was deprecated. Perhaps an example could be added to the PHB or Uses/python.mk? >> > I'm sure the Python section of the PHB could use some attention. It > still references the old USE_PYTHON and > bsd.python.mk instead of USES=python and Uses/python.mk among other things. > > The format I mentioned is the one I have seen in most Python and Perl > ports, however, Uses/python.mk has a mix > of both styles. I guess "deprecated" was a little strong, that's more > of an official word. "Not so common" might be > more appropriate. To me, it looks cleaner and allows for version > checking. Even still, ${PYTHON_SITELIBDIR} > would be preferable to ${PYTHON_LIBDIR}/site-packages. Putting my python@ hat on, I'd suggest to use this syntax instead: ${PYTHON_PKGNAMEPREFIX}paramiko>0:${PORTSDIR}/security/py-paramiko The main point is to depend on package, not on specific file in the filesystem. But the actual problem is that this port, being a python script, make it effectively useless when installing from a package. Because the dependencies are defined as BUILD one, while it actually needs them to run. So, they should be defined as RUN_DEPENDS only or, if the port checks of their existence withing installation process, both on BUILD_ and RUN_DEPENDS. -- Regards, Ruslan T.O.S. Of Reality