From owner-freebsd-multimedia  Tue Jul 22 14:23:45 1997
Return-Path: <owner-freebsd-multimedia>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id OAA29392
          for multimedia-outgoing; Tue, 22 Jul 1997 14:23:45 -0700 (PDT)
Received: from Octopussy.MI.Uni-Koeln.DE (Octopussy.MI.Uni-Koeln.DE [134.95.166.20])
          by hub.freebsd.org (8.8.5/8.8.5) with SMTP id OAA29384;
          Tue, 22 Jul 1997 14:23:42 -0700 (PDT)
Received: from x14.mi.uni-koeln.de (annexr2-45.slip.Uni-Koeln.DE) by Octopussy.MI.Uni-Koeln.DE with SMTP id AA19139
  (5.67b/IDA-1.5); Tue, 22 Jul 1997 23:23:00 +0200
Received: (from se@localhost) by x14.mi.uni-koeln.de (8.8.6/8.6.9) id XAA17852; Tue, 22 Jul 1997 23:22:02 +0200 (CEST)
X-Face: "<d]#=8pzx);RzeqSKI86OVa7=!0/(uRa.+B.9Z9\eNUn@UG?!`y7yt2dFNn%k4'.}](uE%
 yCO)$e&Y1%3EO~ifu6Q-#YUM&JZ't,}JkPnAz,8Dj33u%@GBi%[Y#LHz$]h7a<p4)-jKI7~sKjlP-^
 EvA[G;]v&0]W!EL%shs,{7x0|oqN4YVIs5,NI#,V{9"WF):5&RkOhyj*#-IAG}Tnu;YCF,d
Message-Id: <19970722232201.55387@mi.uni-koeln.de>
Date: Tue, 22 Jul 1997 23:22:01 +0200
From: Stefan Esser <se@FreeBSD.ORG>
To: Bruce Evans <bde@zeta.org.au>
Cc: hackers@FreeBSD.ORG, luigi@labinfo.iet.unipi.it, multimedia@FreeBSD.ORG,
        rhh@ct.picker.com
Subject: Re: snd driver attach routine
References: <199707211133.VAA10007@godzilla.zeta.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.74
In-Reply-To: <199707211133.VAA10007@godzilla.zeta.org.au>; from Bruce Evans on Mon, Jul 21, 1997 at 09:33:47PM +1000
Sender: owner-freebsd-multimedia@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Jul 21, Bruce Evans <bde@zeta.org.au> wrote:
> >I could easily change the return type of 
> >the PCI attach function. Should I ???
> 
> If anything is attached above the driver level, then you need a status
> from the driver attach to decide whether to clean up or attach more.
> For ISA, only interrupts are attached at a high level, but they shouldn't
> be, so ISA attach function shouldn't need to return status (but they
> should clean up if they fail).  I'm not sure about PCI.

Ok. I'll make the PCI code in -current expect the
drivers' attach() functions to return a success
indication, but will for now leave the code in 2.2 
alone ...

Don't know when I'll get around to adding the new
PCI probe/attach framework, so don't hold your your
breath :)

Regards, STefan