Date: Tue, 23 Aug 2016 13:53:10 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304703 - head/include/xlocale Message-ID: <CD046664-4C4B-49CA-B005-C05EDE9694AC@gmail.com> In-Reply-To: <201608232033.u7NKXuZ9054093@repo.freebsd.org> References: <201608232033.u7NKXuZ9054093@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Aug 23, 2016, at 13:33, Andrey A. Chernov <ache@FreeBSD.org> wrote: >=20 > Author: ache > Date: Tue Aug 23 20:33:56 2016 > New Revision: 304703 > URL: https://svnweb.freebsd.org/changeset/base/304703 >=20 > Log: > LC_*_MASK bit shifting order was partially broken from the initial = commit > time at year 2012. Only LC_COLLATE_MASK and LC_CTYPE_MASK are in the > right order. >=20 > The order here should match XLC_* from "xlocale_private.h" which, in = turn, > match LC_* publicly visible order from <locale.h> which determines = how > locale components are stored in the structure. > LC_*_MASK -> XLC_* translation done as "ffs(mask) - 1" in the = querylocale() > and equivalent shift loop in the newlocale(), so mapped to some wrong > components (excluding two mentioned above). >=20 > Formally the fix is ABI breakage, but old code using those masks > never works properly in any case. > Only newlocale() and querylocale() are affected. >=20 > MFC after: 7 days >=20 > Modified: > head/include/xlocale/_locale.h Should __FreeBSD_version be bumped? Thanks, -Ngie --Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXvLe3AAoJEPWDqSZpMIYVgl0QAJRNqTv9K7PbWcQh/m/4s+TV nbpgZqwkJ9uweecBWuGXth89FA+WEDLm2aluSmiADpTxhEp5hZJ+uAaIded57pXz 96Npmsh4+EzKt8FUyI3BlVPhRRP5A+JsJBkce2JA+4cE9d1iiRWP69qWRxBjJVEz R1/Cy/PlUGxVZ0v+EQ71reeZ8Tk0ko+yafpVjwPlOqBNzgXarHZ5PIpMXF/Q5O19 BPRifcU7w4kZ7avdjrwunph3yp7jad/lUbdjwqgIZcYe2bkciwccgn2azzycFxy/ GEeqgyAQXkGfbBAgpwK9msOgxQvqW8zfYnpEQMhO6MXQywqaIwspELcsaLMzm8/B 2KLgWzk0mFbu6WeS9NbgdMbrWrEAqi41S83HvAgObDeJXjT8XiuoG1t8TdJku66I HAQtJ5b1hGq6RG3ubei/Ya0uA0pevKtSnzKVC9lC9yX5m17cq27jkA9CuooDQ/l/ bnkhuRE08kNpkLkYOXOvwu91Yn5dyUmaQtTWOKlttbG3iPsPT0QNLmX491KsY/4I 6cZCNCgFPYFuZQ1GobQ8m6/omfUE2i6QBCCilcoQ7xUDdwLHoZI+aWhtfbryBl8p oDNOxOV0E/YqCOIE+6ujejEDwF95/M/1x04vn0qEOjWKiI4Ve1uRWuVN5Wo1Hj/w 2ol2OgtGcSBLw3uvvSWb =DfR5 -----END PGP SIGNATURE----- --Apple-Mail=_1841782D-4B2F-4847-A4B0-18B39710379A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CD046664-4C4B-49CA-B005-C05EDE9694AC>