From owner-svn-src-all@freebsd.org Tue Nov 10 13:36:21 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05023A2A9DF; Tue, 10 Nov 2015 13:36:21 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F75E1C35; Tue, 10 Nov 2015 13:36:20 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmvv187 with SMTP id v187so8200334wmv.1; Tue, 10 Nov 2015 05:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=0VZTP7uZbhkdzIFOqQJVBis4EkH2kcD/xCm2OQBBdrY=; b=QhCPFoi/6muSRYIjoAlwdRkuJposAtLmcHLex8m2V8CrTpiFRLFu2HGPZaKrRBY8Da GywCPol5ku6gvRPnADsfKvtR/jVMa5JZuEAvs+EVzO/mNVeIEUZ3UvFxwI+ubXN3QXz5 50PevZjRjSK6XSy9rXsusWe7D0870xC/YtTP/RkOEg2KxCiK9t0csQoF0iIGwWcMO7Gy QBqSAsh7Dgt/S/U3yZcHMpbrQqualJVpTOkWWsag8IA3hg2pnacBWag56fhhOj8A15Jc wTe/SOQlhc+/auFLxb+qTkVzoitHK74mzIYHK7Qdo+HcN8j4dFRvX1GBf+E95t50p208 0ppw== X-Received: by 10.28.144.138 with SMTP id s132mr4594202wmd.97.1447162579115; Tue, 10 Nov 2015 05:36:19 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id 194sm4156407wmh.19.2015.11.10.05.36.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 05:36:18 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 10 Nov 2015 14:36:15 +0100 From: Baptiste Daroussin To: Andrey Chernov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290637 - head/lib/libc/locale Message-ID: <20151110133615.GL10134@ivaldir.etoilebsd.net> References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/ZYM6PqDyfNytx60" Content-Disposition: inline In-Reply-To: <5641EF26.8060600@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 13:36:21 -0000 --/ZYM6PqDyfNytx60 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: > On 10.11.2015 16:04, Baptiste Daroussin wrote: > > On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: > >> On 10.11.2015 11:11, Baptiste Daroussin wrote: > >>> Author: bapt > >>> Date: Tue Nov 10 08:11:27 2015 > >>> New Revision: 290637 > >>> URL: https://svnweb.freebsd.org/changeset/base/290637 > >>> > >>> Log: > >>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales > >>> as it used to be in previous version of the locales. Returning > >>> "POSIX" has too many fallouts. > >> > >> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be > >> different with real US-ASCII. It is what glibc returns for C/POSIX > >> locale and most ports expected, being linux-oriented. > >> > > I thought about it, but in the end it is probably safer for now that nl= _langinfo > > return US-ASCII as it did in the past, to reduce breakage with FreeBSD = only code > > that maybe be existing ou there. >=20 > All FreeBSD code I know never check locale this way. IMHO probability of > potential danger to meet some linux-oriented port with this check is > much much higher than to meet similar FreeBSD only code in the wild. In > any case, changing collate order from A-Za-z to aA-zZ we do just now > have much higher probability to break unknown FreeBSD only code, so one > breaking change can go with other one together. >=20 That is true, except that the new collation thing is invalidated as soon as= you set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a workaroun= d while changing the return value of nl_langinfo() is not workaroundable. --- Bapt --/ZYM6PqDyfNytx60 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEUEARECAAYFAlZB8s8ACgkQ8kTtMUmk6EzJIgCeN7YthORHwzLKgrJ9JeXPmP4v LaUAmNjGL+a9PxwZDWnHPmNvE5vPi6I= =Jaf2 -----END PGP SIGNATURE----- --/ZYM6PqDyfNytx60--