From owner-svn-src-all@freebsd.org  Tue May 22 07:35:34 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9B87EEAE9E;
 Tue, 22 May 2018 07:35:34 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 59AD187AFC;
 Tue, 22 May 2018 07:35:34 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from mail-it0-f48.google.com (mail-it0-f48.google.com
 [209.85.214.48])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: mmacy)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 1D0F71CD3B;
 Tue, 22 May 2018 07:35:34 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: by mail-it0-f48.google.com with SMTP id c3-v6so24192113itj.4;
 Tue, 22 May 2018 00:35:34 -0700 (PDT)
X-Gm-Message-State: ALKqPwcIx4T5N6sQTuWTjtxFOvvB2Va5LDCuIHYoex3vyV9L9HgQh5OA
 6lKcfV0KfzkA57R+Cj2p6lsUavNXPxdkLzA9c4o=
X-Google-Smtp-Source: AB8JxZqiFcRKi8h40REkxONklB0YX0/i6+2MZEt9JvAUJ4hFxV5LWP8fFU/HsCV8lyvDD9jYUumQnYA9tjmy7Pe9yzo=
X-Received: by 2002:a24:5a85:: with SMTP id
 v127-v6mr291370ita.128.1526974533374; 
 Tue, 22 May 2018 00:35:33 -0700 (PDT)
MIME-Version: 1.0
References: <201805210834.w4L8YAcD022948@repo.freebsd.org>
 <CAF6rxg=0N3x+3KuxrS+sHtt6TxpN8Q8yMAAKjTT=ro3vyiyxJQ@mail.gmail.com>
In-Reply-To: <CAF6rxg=0N3x+3KuxrS+sHtt6TxpN8Q8yMAAKjTT=ro3vyiyxJQ@mail.gmail.com>
From: Matthew Macy <mmacy@freebsd.org>
Date: Tue, 22 May 2018 00:35:22 -0700
X-Gmail-Original-Message-ID: <CAPrugNrJLd0FnMa-A0+9ucKFE0WJZZYycpJzU8wyTfbRTBwHcA@mail.gmail.com>
Message-ID: <CAPrugNrJLd0FnMa-A0+9ucKFE0WJZZYycpJzU8wyTfbRTBwHcA@mail.gmail.com>
Subject: Re: svn commit: r333968 - in head/sys: netinet netinet6
To: Eitan Adler <lists@eitanadler.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.26
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 07:35:34 -0000

On Tue, May 22, 2018 at 00:33 Eitan Adler <lists@eitanadler.com> wrote:

> On 21 May 2018 at 01:34, Matt Macy <mmacy@freebsd.org> wrote:
> > Author: mmacy
> > Date: Mon May 21 08:34:10 2018
> > New Revision: 333968
> > URL: https://svnweb.freebsd.org/changeset/base/333968
> >
> > Log:
> >   in(6)_mcast: Expand out vnet set / restore macro so that they work in
> a conditional block
>
> Why not simply add missing {} s or modifying the macro to use "do { }
> while(false)"  ?
>

It declares variables which would go out of scope.


> --
> Eitan Adler
>