From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 29 07:35:47 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3A4BB868 for ; Sun, 29 Sep 2013 07:35:47 +0000 (UTC) (envelope-from michael@fuckner.net) Received: from mo6-p00-ob.rzone.de (mo6-p00-ob.rzone.de [IPv6:2a01:238:20a:202:5300::1]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C29E32A25 for ; Sun, 29 Sep 2013 07:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1380440143; l=2979; s=domk; d=fuckner.net; h=Content-Type:MIME-Version:Subject:References:In-Reply-To:To: Reply-To:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=ZtfCc/TnpEPyGtEw8s5tLR1wkYc=; b=WsEGpLq0QaEMmAjOk5GExKhY10XncfTzMK8NSL72QCsFmwZ/qTZM2CvJ2JJMZxhsIdf AmWQNVeiSP8/X1h+seGJThPjuu+k2PJenAMvROnPr61CapCvH7FSYNWSf/5N8zLhx/xnj FvO+jC9Tp6aIPgT8Mlu4nIlP1Zgvz1UqhCU= X-RZG-AUTH: :IWUHfUGtd9+6EujMWHx57N4dWae4bmTEGbkn8hussqFHiy/c+oYVPeezIVIZYA== X-RZG-CLASS-ID: mo00 Received: from ptangptang.store (com4.strato.de [81.169.145.237]) by smtp.strato.de (RZmta 32.6 AUTH) with (TLSv1.0:EDH-RSA-DES-CBC3-SHA encrypted) ESMTPSA id I01c1ap8T53l0Z ; Sun, 29 Sep 2013 09:35:31 +0200 (CEST) Date: Sun, 29 Sep 2013 09:35:31 +0200 (CEST) From: Michael Fuckner To: FreeBSD-SCSI , dgilbert@interlog.com Message-ID: <1450642901.368121.1380440131388.open-xchange@com4.strato.de> In-Reply-To: <52473B95.2030705@interlog.com> References: <52473B95.2030705@interlog.com> Subject: Re: LSI 9300-4i4e support MIME-Version: 1.0 X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev20 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Michael Fuckner List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Sep 2013 07:35:47 -0000 Hi, did you try the driver provided by lsi? It seems to be for FreeBSD 9.0, but perhaps it is also working. http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e.aspx -> Support & Downloads -> Driver -> FreeBSD? Seems like 12GBit is not supported inbox right now- I am still waiting for my 12GBit HBA Card :( Regards, Michael! > Douglas Gilbert hat am 28. September 2013 um 22:27 > geschrieben: > > > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > SAS HBA (relatively new: 12 Gbps). Do any more recent > RCs or betas have support for it? > > Doug Gilbert > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 29 15:55:42 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 627915FA for ; Sun, 29 Sep 2013 15:55:42 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from smtp.infotech.no (smtp.infotech.no [82.134.31.41]) by mx1.freebsd.org (Postfix) with ESMTP id 20CA52C63 for ; Sun, 29 Sep 2013 15:55:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id A475D2041D2; Sun, 29 Sep 2013 17:55:39 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MD-WppazB87d; Sun, 29 Sep 2013 17:55:39 +0200 (CEST) Received: from [10.7.0.30] (unknown [10.7.0.30]) by smtp.infotech.no (Postfix) with ESMTPA id 0E2C32041D0; Sun, 29 Sep 2013 17:55:38 +0200 (CEST) Message-ID: <52484D60.60105@interlog.com> Date: Sun, 29 Sep 2013 11:55:12 -0400 From: Douglas Gilbert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Michael Fuckner , FreeBSD-SCSI Subject: Re: LSI 9300-4i4e support References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> In-Reply-To: <1450642901.368121.1380440131388.open-xchange@com4.strato.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dgilbert@interlog.com List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Sep 2013 15:55:42 -0000 The mpslsi3.ko modules provided by LSI in their support pages for the 9300-4i4e does work in 9.1 Release sufficiently well to bring up the system. There is no sensible report about it discovering this HBA in dmesg, just a thousand or so of these: kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid Target ID kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable error But it does get there in the end. LSI, if you are reading this, why not add 9.1 Release to your driver support zip file for the 9300 family? Doug Gilbert On 13-09-29 03:35 AM, Michael Fuckner wrote: > Hi, > did you try the driver provided by lsi? It seems to be for FreeBSD 9.0, but > perhaps it is also working. > http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e.aspx -> > Support & Downloads -> Driver -> FreeBSD? > Seems like 12GBit is not supported inbox right now- I am still waiting for my > 12GBit HBA Card :( > Regards, > Michael! > > > Douglas Gilbert hat am 28. September 2013 um 22:27 geschrieben: > > > > > > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > > SAS HBA (relatively new: 12 Gbps). Do any more recent > > RCs or betas have support for it? > > > > Doug Gilbert > > _______________________________________________ > > freebsd-scsi@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-scsi > > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Sun Sep 29 17:37:39 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9960C73D for ; Sun, 29 Sep 2013 17:37:39 +0000 (UTC) (envelope-from michael@fuckner.net) Received: from mo6-p00-ob.rzone.de (mo6-p00-ob.rzone.de [IPv6:2a01:238:20a:202:5300::1]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2D52B2013 for ; Sun, 29 Sep 2013 17:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1380476255; l=1774; s=domk; d=fuckner.net; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=5oDdspuOVm9nTvIgAETiL9QpXQY=; b=ISR9nooKnH9Q/xVi+mlGJ27zEh3DiHStDbKk4k/qirpHk6Qm3sQ+RoheriKWo6dYkfb OqGzuCJ9witCKLd92DZmcPQfPHW8+8+aOWzxO6JViNfp3ExO85OXmSC0GOKbY4/S9z5ZG egVWb6Q2ivTlXGXsx6HW8Fe+mhn2XfcQyBQ= X-RZG-AUTH: :IWUHfUGtd9+6EujMWHx57N4dWae4bmTL/JIGbzkGUoozgkO5q1lND0BO+W4SAg== X-RZG-CLASS-ID: mo00 Received: from [10.1.2.128] (port-233.pppoe.wtnet.de [84.46.0.233]) by smtp.strato.de (RZmta 32.6 AUTH) with (TLSv1.0:DHE-RSA-AES256-SHA encrypted) ESMTPSA id d0706dp8TGXgyK ; Sun, 29 Sep 2013 19:37:23 +0200 (CEST) Message-ID: <52486553.4020004@fuckner.net> Date: Sun, 29 Sep 2013 19:37:23 +0200 From: Michael Fuckner User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: dgilbert@interlog.com, FreeBSD-SCSI Subject: Re: LSI 9300-4i4e support References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> <52484D60.60105@interlog.com> In-Reply-To: <52484D60.60105@interlog.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Sep 2013 17:37:39 -0000 Or even add support for 9.2 which will be released tomorrow. Regards, Michael! On 9/29/2013 5:55 PM, Douglas Gilbert wrote: > The mpslsi3.ko modules provided by LSI in their support > pages for the 9300-4i4e does work in 9.1 Release sufficiently > well to bring up the system. > > There is no sensible report about it discovering this HBA in > dmesg, just a thousand or so of these: > kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 > kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid Target ID > kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable error > > But it does get there in the end. > > > LSI, if you are reading this, why not add 9.1 Release to > your driver support zip file for the 9300 family? > > Doug Gilbert > > On 13-09-29 03:35 AM, Michael Fuckner wrote: >> Hi, >> did you try the driver provided by lsi? It seems to be for FreeBSD >> 9.0, but >> perhaps it is also working. >> http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e.aspx >> -> >> Support & Downloads -> Driver -> FreeBSD? >> Seems like 12GBit is not supported inbox right now- I am still waiting >> for my >> 12GBit HBA Card :( >> Regards, >> Michael! >> >> > Douglas Gilbert hat am 28. September 2013 >> um 22:27 geschrieben: >> > >> > >> > I've noticed that 9.1 does not recognize a LSI 9300-4i4e >> > SAS HBA (relatively new: 12 Gbps). Do any more recent >> > RCs or betas have support for it? >> > >> > Doug Gilbert >> > _______________________________________________ >> > freebsd-scsi@freebsd.org mailing list >> > http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> > To unsubscribe, send any mail to >> "freebsd-scsi-unsubscribe@freebsd.org" > From owner-freebsd-scsi@FreeBSD.ORG Mon Sep 30 11:06:51 2013 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9921CE75 for ; Mon, 30 Sep 2013 11:06:51 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 864B02BFE for ; Mon, 30 Sep 2013 11:06:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r8UB6pqS053598 for ; Mon, 30 Sep 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r8UB6pUS053596 for freebsd-scsi@FreeBSD.org; Mon, 30 Sep 2013 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 30 Sep 2013 11:06:51 GMT Message-Id: <201309301106.r8UB6pUS053596@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-scsi@FreeBSD.org Subject: Current problem reports assigned to freebsd-scsi@FreeBSD.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Sep 2013 11:06:51 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/179932 scsi [ciss] ciss i/o stall problem with HP Bl Gen8 (and HP o kern/178795 scsi [mps] MSI for mps driver doesn't work under vmware o kern/165982 scsi [mpt] mpt instability, drive resets, and losses on Fre o kern/165740 scsi [cam] SCSI code must drain callbacks before free f kern/162256 scsi [mpt] QUEUE FULL EVENT and 'mpt_cam_event: 0x0' o docs/151336 scsi Missing documentation of scsi_ and ata_ functions in c o kern/148083 scsi [aac] Strange device reporting o kern/144648 scsi [aac] Strange values of speed and bus width in dmesg o kern/142351 scsi [mpt] LSILogic driver performance problems o kern/134488 scsi [mpt] MPT SCSI driver probes max. 8 LUNs per device o kern/130621 scsi [mpt] tranfer rate is inscrutable slow when use lsi213 f kern/129602 scsi [ahd] ahd(4) gets confused and wedges SCSI bus f kern/123674 scsi [ahc] ahc driver dumping o sparc/121676 scsi [iscsi] iscontrol do not connect iscsi-target on sparc 14 problems total. From owner-freebsd-scsi@FreeBSD.ORG Mon Sep 30 11:11:07 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4E6B2744 for ; Mon, 30 Sep 2013 11:11:07 +0000 (UTC) (envelope-from Kashyap.Desai@lsi.com) Received: from db9outboundpool.messaging.microsoft.com (mail-db9lp0248.outbound.messaging.microsoft.com [213.199.154.248]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A86EA2DB2 for ; Mon, 30 Sep 2013 11:11:06 +0000 (UTC) Received: from mail74-db9-R.bigfish.com (10.174.16.225) by DB9EHSOBE014.bigfish.com (10.174.14.77) with Microsoft SMTP Server id 14.1.225.22; Mon, 30 Sep 2013 10:55:49 +0000 Received: from mail74-db9 (localhost [127.0.0.1]) by mail74-db9-R.bigfish.com (Postfix) with ESMTP id 2A39A680136; Mon, 30 Sep 2013 10:55:49 +0000 (UTC) X-Forefront-Antispam-Report: CIP:192.19.193.42; KIP:(null); UIP:(null); IPV:NLI; H:paledge01.lsi.com; RD:paledge01.lsi.com; EFVD:NLI X-SpamScore: -6 X-BigFish: VPS-6(zzbb2dI98dI9371I936eI542I1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h17326ah1de097h186068h8275bh8275dhz2fh2a8h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5h1155h) Received-SPF: pass (mail74-db9: domain of lsi.com designates 192.19.193.42 as permitted sender) client-ip=192.19.193.42; envelope-from=Kashyap.Desai@lsi.com; helo=paledge01.lsi.com ; ge01.lsi.com ; Received: from mail74-db9 (localhost.localdomain [127.0.0.1]) by mail74-db9 (MessageSwitch) id 1380538547591931_20038; Mon, 30 Sep 2013 10:55:47 +0000 (UTC) Received: from DB9EHSMHS013.bigfish.com (unknown [10.174.16.241]) by mail74-db9.bigfish.com (Postfix) with ESMTP id 83F152500040; Mon, 30 Sep 2013 10:55:47 +0000 (UTC) Received: from paledge01.lsi.com (192.19.193.42) by DB9EHSMHS013.bigfish.com (10.174.14.23) with Microsoft SMTP Server (TLS) id 14.16.227.3; Mon, 30 Sep 2013 10:55:46 +0000 Received: from PALHUB01.lsi.com (128.94.213.114) by PALEDGE01.lsi.com (192.19.193.42) with Microsoft SMTP Server (TLS) id 8.3.298.1; Mon, 30 Sep 2013 06:58:11 -0400 Received: from inbexch01.lsi.com (135.36.98.37) by PALHUB01.lsi.com (128.94.213.114) with Microsoft SMTP Server (TLS) id 8.3.298.1; Mon, 30 Sep 2013 06:55:45 -0400 Received: from inbmail01.lsi.com ([135.36.98.64]) by inbexch01.lsi.com ([135.36.98.37]) with mapi; Mon, 30 Sep 2013 16:25:42 +0530 From: "Desai, Kashyap" To: Michael Fuckner , "dgilbert@interlog.com" , FreeBSD-SCSI Date: Mon, 30 Sep 2013 16:25:41 +0530 Subject: RE: LSI 9300-4i4e support Thread-Topic: LSI 9300-4i4e support Thread-Index: Ac69OqY4VaWn8Tk/Rt6FADH76jfYQwAkFQ5g Message-ID: References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> <52484D60.60105@interlog.com> <52486553.4020004@fuckner.net> In-Reply-To: <52486553.4020004@fuckner.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: lsi.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: "McConnell, Stephen" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Sep 2013 11:11:07 -0000 Michael: LSI 9300 card will work with driver which you have posted here fr= om lsi's external site works for you.=20 Prints which you have pointed for CAM status error are resolved in our late= st driver, but still not posted to external site because we are waiting for= Internal driver GA. Regarding upstream submission of I have seen that Steve McConnnel= l is working with Ken D Merry to get driver inbox. Added Steve M.. to give you more insight on mpslsi3 inbox. ` Kashyap > -----Original Message----- > From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- > scsi@freebsd.org] On Behalf Of Michael Fuckner > Sent: Sunday, September 29, 2013 11:07 PM > To: dgilbert@interlog.com; FreeBSD-SCSI > Subject: Re: LSI 9300-4i4e support >=20 > Or even add support for 9.2 which will be released tomorrow. >=20 > Regards, > Michael! >=20 > On 9/29/2013 5:55 PM, Douglas Gilbert wrote: > > The mpslsi3.ko modules provided by LSI in their support pages for the > > 9300-4i4e does work in 9.1 Release sufficiently well to bring up the > > system. > > > > There is no sensible report about it discovering this HBA in dmesg, > > just a thousand or so of these: > > kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 > > kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid Target > ID > > kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable error > > > > But it does get there in the end. > > > > > > LSI, if you are reading this, why not add 9.1 Release to your driver > > support zip file for the 9300 family? > > > > Doug Gilbert > > > > On 13-09-29 03:35 AM, Michael Fuckner wrote: > >> Hi, > >> did you try the driver provided by lsi? It seems to be for FreeBSD > >> 9.0, but perhaps it is also working. > >> http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e.a > >> spx > >> -> > >> Support & Downloads -> Driver -> FreeBSD? > >> Seems like 12GBit is not supported inbox right now- I am still > >> waiting for my 12GBit HBA Card :( Regards, > >> Michael! > >> > >> > Douglas Gilbert hat am 28. September 2013 > >> um 22:27 geschrieben: > >> > > >> > > >> > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > SAS > >> HBA (relatively new: 12 Gbps). Do any more recent > RCs or betas > >> have support for it? > >> > > >> > Doug Gilbert > >> > _______________________________________________ > >> > freebsd-scsi@freebsd.org mailing list > > >> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi > >> > To unsubscribe, send any mail to > >> "freebsd-scsi-unsubscribe@freebsd.org" > > >=20 > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@FreeBSD.ORG Tue Oct 1 15:03:34 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9E7EC6AA for ; Tue, 1 Oct 2013 15:03:34 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from smtp.infotech.no (smtp.infotech.no [82.134.31.41]) by mx1.freebsd.org (Postfix) with ESMTP id 261C5216E for ; Tue, 1 Oct 2013 15:03:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id A5E67204269; Tue, 1 Oct 2013 17:03:25 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zq87VM8ek5oO; Tue, 1 Oct 2013 17:03:25 +0200 (CEST) Received: from [10.7.0.30] (unknown [10.7.0.30]) by smtp.infotech.no (Postfix) with ESMTPA id 8954C20425C; Tue, 1 Oct 2013 17:03:22 +0200 (CEST) Message-ID: <524AE41D.2020807@interlog.com> Date: Tue, 01 Oct 2013 11:02:53 -0400 From: Douglas Gilbert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "Desai, Kashyap" , Michael Fuckner , FreeBSD-SCSI Subject: Re: LSI 9300-4i4e support References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> <52484D60.60105@interlog.com> <52486553.4020004@fuckner.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "McConnell, Stephen" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dgilbert@interlog.com List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 15:03:34 -0000 Yesterday I did an upgrade from 9.1 release to 9.2 release on a system with a LSI 9300-4i4e in it and a SAS disk attached to the 4i4e holding the rootfs. That worked albeit with the same CAM status error flood during each boot. So the mpslsi3 driver for 9.0 release provided by LSI works (with some noise) for 9.1 release and 9.2 release. Doug Gilbert On 13-09-30 06:55 AM, Desai, Kashyap wrote: > Michael: > > LSI 9300 card will work with driver which you have posted here from lsi's external site works for you. > > Prints which you have pointed for CAM status error are resolved in our latest driver, but still not posted to external site because we are waiting for Internal driver GA. > > Regarding upstream submission of I have seen that Steve McConnnell is working with Ken D Merry to get driver inbox. > > Added Steve M.. to give you more insight on mpslsi3 inbox. > > ` Kashyap > >> -----Original Message----- >> From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- >> scsi@freebsd.org] On Behalf Of Michael Fuckner >> Sent: Sunday, September 29, 2013 11:07 PM >> To: dgilbert@interlog.com; FreeBSD-SCSI >> Subject: Re: LSI 9300-4i4e support >> >> Or even add support for 9.2 which will be released tomorrow. >> >> Regards, >> Michael! >> >> On 9/29/2013 5:55 PM, Douglas Gilbert wrote: >>> The mpslsi3.ko modules provided by LSI in their support pages for the >>> 9300-4i4e does work in 9.1 Release sufficiently well to bring up the >>> system. >>> >>> There is no sensible report about it discovering this HBA in dmesg, >>> just a thousand or so of these: >>> kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid Target >> ID >>> kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable error >>> >>> But it does get there in the end. >>> >>> >>> LSI, if you are reading this, why not add 9.1 Release to your driver >>> support zip file for the 9300 family? >>> >>> Doug Gilbert >>> >>> On 13-09-29 03:35 AM, Michael Fuckner wrote: >>>> Hi, >>>> did you try the driver provided by lsi? It seems to be for FreeBSD >>>> 9.0, but perhaps it is also working. >>>> http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e.a >>>> spx >>>> -> >>>> Support & Downloads -> Driver -> FreeBSD? >>>> Seems like 12GBit is not supported inbox right now- I am still >>>> waiting for my 12GBit HBA Card :( Regards, >>>> Michael! >>>> >>>> > Douglas Gilbert hat am 28. September 2013 >>>> um 22:27 geschrieben: >>>> > >>>> > >>>> > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > SAS >>>> HBA (relatively new: 12 Gbps). Do any more recent > RCs or betas >>>> have support for it? >>>> > >>>> > Doug Gilbert >>>> > _______________________________________________ >>>> > freebsd-scsi@freebsd.org mailing list > >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >>>> > To unsubscribe, send any mail to >>>> "freebsd-scsi-unsubscribe@freebsd.org" >>> >> >> _______________________________________________ >> freebsd-scsi@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" > > > From owner-freebsd-scsi@FreeBSD.ORG Tue Oct 1 20:03:59 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 04236567 for ; Tue, 1 Oct 2013 20:03:59 +0000 (UTC) (envelope-from Stephen.McConnell@lsi.com) Received: from db9outboundpool.messaging.microsoft.com (mail-db9lp0250.outbound.messaging.microsoft.com [213.199.154.250]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 61BB125C8 for ; Tue, 1 Oct 2013 20:03:57 +0000 (UTC) Received: from mail2-db9-R.bigfish.com (10.174.16.248) by DB9EHSOBE026.bigfish.com (10.174.14.89) with Microsoft SMTP Server id 14.1.225.22; Tue, 1 Oct 2013 20:03:49 +0000 Received: from mail2-db9 (localhost [127.0.0.1]) by mail2-db9-R.bigfish.com (Postfix) with ESMTP id AEF941C0147; Tue, 1 Oct 2013 20:03:49 +0000 (UTC) X-Forefront-Antispam-Report: CIP:192.19.220.66; KIP:(null); UIP:(null); IPV:NLI; H:cosedge01.lsi.com; RD:cosedge01.lsi.com; EFVD:NLI X-SpamScore: -7 X-BigFish: VPS-7(zzbb2dI98dI9371I936eI542I1432I1447Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hza3hz1de098h17326ah1de097h186068h8275bh8275dhz2fh2a8h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1dfeh1dffh1fe8h1ff5h1155h) Received-SPF: pass (mail2-db9: domain of lsi.com designates 192.19.220.66 as permitted sender) client-ip=192.19.220.66; envelope-from=Stephen.McConnell@lsi.com; helo=cosedge01.lsi.com ; ge01.lsi.com ; Received: from mail2-db9 (localhost.localdomain [127.0.0.1]) by mail2-db9 (MessageSwitch) id 138065782751755_16665; Tue, 1 Oct 2013 20:03:47 +0000 (UTC) Received: from DB9EHSMHS028.bigfish.com (unknown [10.174.16.239]) by mail2-db9.bigfish.com (Postfix) with ESMTP id 087C650007B; Tue, 1 Oct 2013 20:03:47 +0000 (UTC) Received: from cosedge01.lsi.com (192.19.220.66) by DB9EHSMHS028.bigfish.com (10.174.14.38) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 1 Oct 2013 20:03:42 +0000 Received: from coshub01.lsi.com (135.142.2.64) by COSEDGE01.lsi.com (192.19.220.66) with Microsoft SMTP Server (TLS) id 8.3.298.1; Tue, 1 Oct 2013 14:06:18 -0600 Received: from cosmail03.lsi.com ([172.21.36.37]) by coshub01.lsi.com ([135.142.2.64]) with mapi; Tue, 1 Oct 2013 14:03:24 -0600 From: "McConnell, Stephen" To: "dgilbert@interlog.com" , "Desai, Kashyap" , Michael Fuckner , FreeBSD-SCSI Date: Tue, 1 Oct 2013 14:03:22 -0600 Subject: RE: LSI 9300-4i4e support Thread-Topic: LSI 9300-4i4e support Thread-Index: Ac6+t4+fctUlJqT2Q8SQvH9BghbKZAAKDBKQ Message-ID: References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> <52484D60.60105@interlog.com> <52486553.4020004@fuckner.net> <524AE41D.2020807@interlog.com> In-Reply-To: <524AE41D.2020807@interlog.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: lsi.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 20:03:59 -0000 Hi Doug, Thanks for the update. As Kashyap noted, the issue with bunches o= f messages has been fixed in our pre-GCA version. The reason that we have = not added the 9.1 driver version to our zip is that it needs to go through = our testing procedure first. It is scheduled to be released before the end= of the year. 9.2 will need to go through the same process and I don't kno= w when that's going to be finalized yet. As far as getting mpslsi3 upstream, I don't know exactly what's going to ha= ppen at this point. We (LSI) are trying to convince the FreeBSD community = that the Gen2 and Gen3 drivers need to be separated and we're getting a lit= tle understandable resistance. LSI separated these drivers quite a while a= nd it's unlikely that we'll merge Gen2 and Gen3 functionality back into one= driver. So, we need come up with some solution. Regards, Steve McConnell -----Original Message----- From: Douglas Gilbert [mailto:dgilbert@interlog.com]=20 Sent: Tuesday, October 01, 2013 9:03 AM To: Desai, Kashyap; Michael Fuckner; FreeBSD-SCSI Cc: McConnell, Stephen Subject: Re: LSI 9300-4i4e support Yesterday I did an upgrade from 9.1 release to 9.2 release on a system with= a LSI 9300-4i4e in it and a SAS disk attached to the 4i4e holding the root= fs. That worked albeit with the same CAM status error flood during each boo= t. So the mpslsi3 driver for 9.0 release provided by LSI works (with some nois= e) for 9.1 release and 9.2 release. Doug Gilbert On 13-09-30 06:55 AM, Desai, Kashyap wrote: > Michael: > > LSI 9300 card will work with driver which you have posted here = from lsi's external site works for you. > > Prints which you have pointed for CAM status error are resolved in our la= test driver, but still not posted to external site because we are waiting f= or Internal driver GA. > > Regarding upstream submission of I have seen that Steve McConnn= ell is working with Ken D Merry to get driver inbox. > > Added Steve M.. to give you more insight on mpslsi3 inbox. > > ` Kashyap > >> -----Original Message----- >> From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd-=20 >> scsi@freebsd.org] On Behalf Of Michael Fuckner >> Sent: Sunday, September 29, 2013 11:07 PM >> To: dgilbert@interlog.com; FreeBSD-SCSI >> Subject: Re: LSI 9300-4i4e support >> >> Or even add support for 9.2 which will be released tomorrow. >> >> Regards, >> Michael! >> >> On 9/29/2013 5:55 PM, Douglas Gilbert wrote: >>> The mpslsi3.ko modules provided by LSI in their support pages for=20 >>> the 9300-4i4e does work in 9.1 Release sufficiently well to bring up=20 >>> the system. >>> >>> There is no sensible report about it discovering this HBA in dmesg,=20 >>> just a thousand or so of these: >>> kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid=20 >>> Target >> ID >>> kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable=20 >>> error >>> >>> But it does get there in the end. >>> >>> >>> LSI, if you are reading this, why not add 9.1 Release to your driver=20 >>> support zip file for the 9300 family? >>> >>> Doug Gilbert >>> >>> On 13-09-29 03:35 AM, Michael Fuckner wrote: >>>> Hi, >>>> did you try the driver provided by lsi? It seems to be for FreeBSD=20 >>>> 9.0, but perhaps it is also working. >>>> http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e >>>> .a >>>> spx >>>> -> >>>> Support & Downloads -> Driver -> FreeBSD? >>>> Seems like 12GBit is not supported inbox right now- I am still=20 >>>> waiting for my 12GBit HBA Card :( Regards, >>>> Michael! >>>> >>>> > Douglas Gilbert hat am 28. September=20 >>>> 2013 um 22:27 geschrieben: >>>> > >>>> > >>>> > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > SAS=20 >>>> HBA (relatively new: 12 Gbps). Do any more recent > RCs or betas=20 >>>> have support for it? >>>> > >>>> > Doug Gilbert >>>> > _______________________________________________ >>>> > freebsd-scsi@freebsd.org mailing list >=20 >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >>>> > To unsubscribe, send any mail to=20 >>>> "freebsd-scsi-unsubscribe@freebsd.org" >>> >> >> _______________________________________________ >> freebsd-scsi@freebsd.org mailing list=20 >> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" > > > From owner-freebsd-scsi@FreeBSD.ORG Tue Oct 1 22:25:49 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4009D782 for ; Tue, 1 Oct 2013 22:25:49 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from smtp.infotech.no (smtp.infotech.no [82.134.31.41]) by mx1.freebsd.org (Postfix) with ESMTP id D54172FE0 for ; Tue, 1 Oct 2013 22:25:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id ACE132041C7; Wed, 2 Oct 2013 00:25:46 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gm1x01Vbwov4; Wed, 2 Oct 2013 00:25:46 +0200 (CEST) Received: from [10.7.0.30] (unknown [10.7.0.30]) by smtp.infotech.no (Postfix) with ESMTPA id 8CC0820416D; Wed, 2 Oct 2013 00:25:45 +0200 (CEST) Message-ID: <524B4BCB.5050503@interlog.com> Date: Tue, 01 Oct 2013 18:25:15 -0400 From: Douglas Gilbert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "McConnell, Stephen" , "Desai, Kashyap" , Michael Fuckner , FreeBSD-SCSI Subject: Re: LSI 9300-4i4e support References: <52473B95.2030705@interlog.com> <1450642901.368121.1380440131388.open-xchange@com4.strato.de> <52484D60.60105@interlog.com> <52486553.4020004@fuckner.net> <524AE41D.2020807@interlog.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dgilbert@interlog.com List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 22:25:49 -0000 On 13-10-01 04:03 PM, McConnell, Stephen wrote: > Hi Doug, Thanks for the update. As Kashyap noted, the issue with bunches of messages has been fixed in our pre-GCA version. The reason that we have not added the 9.1 driver version to our zip is that it needs to go through our testing procedure first. It is scheduled to be released before the end of the year. 9.2 will need to go through the same process and I don't know when that's going to be finalized yet. > > As far as getting mpslsi3 upstream, I don't know exactly what's going to happen at this point. We (LSI) are trying to convince the FreeBSD community that the Gen2 and Gen3 drivers need to be separated and we're getting a little understandable resistance. LSI separated these drivers quite a while and it's unlikely that we'll merge Gen2 and Gen3 functionality back into one driver. So, we need come up with some solution. To summarize (please correct me if need be) for LSI SAS HBAs as things stand now: LSI FreeBSD Linux T10 Legacy ---------------------------------------------------------- Gen1 mpt mptsas ** G2 (3 Gbps), G1 (1.5 Gbps) Gen2 mps mpt2sas G3 (6 Gbps), G2, G1 Gen3 mpslsi3 mpt3sas G4 (12 Gbps), G3, G2 *** Gen4 ??? ??? G5 (24 Gbps), ??? ** the mptsas driver was placed in its own subsystem under drivers/message/fusion . Sense prevailed and mpt2sas and mpt3sas were put in the Linux SCSI subsystem *** so LSI Gen3 SAS HBAs can't talk to the first generation of SATA drives that run at 1.5 Gbps Doug Gilbert > -----Original Message----- > From: Douglas Gilbert [mailto:dgilbert@interlog.com] > Sent: Tuesday, October 01, 2013 9:03 AM > To: Desai, Kashyap; Michael Fuckner; FreeBSD-SCSI > Cc: McConnell, Stephen > Subject: Re: LSI 9300-4i4e support > > Yesterday I did an upgrade from 9.1 release to 9.2 release on a system with a LSI 9300-4i4e in it and a SAS disk attached to the 4i4e holding the rootfs. That worked albeit with the same CAM status error flood during each boot. > > So the mpslsi3 driver for 9.0 release provided by LSI works (with some noise) for 9.1 release and 9.2 release. > > Doug Gilbert > > > On 13-09-30 06:55 AM, Desai, Kashyap wrote: >> Michael: >> >> LSI 9300 card will work with driver which you have posted here from lsi's external site works for you. >> >> Prints which you have pointed for CAM status error are resolved in our latest driver, but still not posted to external site because we are waiting for Internal driver GA. >> >> Regarding upstream submission of I have seen that Steve McConnnell is working with Ken D Merry to get driver inbox. >> >> Added Steve M.. to give you more insight on mpslsi3 inbox. >> >> ` Kashyap >> >>> -----Original Message----- >>> From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- >>> scsi@freebsd.org] On Behalf Of Michael Fuckner >>> Sent: Sunday, September 29, 2013 11:07 PM >>> To: dgilbert@interlog.com; FreeBSD-SCSI >>> Subject: Re: LSI 9300-4i4e support >>> >>> Or even add support for 9.2 which will be released tomorrow. >>> >>> Regards, >>> Michael! >>> >>> On 9/29/2013 5:55 PM, Douglas Gilbert wrote: >>>> The mpslsi3.ko modules provided by LSI in their support pages for >>>> the 9300-4i4e does work in 9.1 Release sufficiently well to bring up >>>> the system. >>>> >>>> There is no sensible report about it discovering this HBA in dmesg, >>>> just a thousand or so of these: >>>> kernel: (probe1022:mpslsi30:0:1023:0): INQUIRY. CDB: 12 0 0 0 24 0 >>>> kernel: (probe1022:mpslsi30:0:1023:0): CAM status: Invalid >>>> Target >>> ID >>>> kernel: (probe1022:mpslsi30:0:1023:0): Error 22, Unretryable >>>> error >>>> >>>> But it does get there in the end. >>>> >>>> >>>> LSI, if you are reading this, why not add 9.1 Release to your driver >>>> support zip file for the 9300 family? >>>> >>>> Doug Gilbert >>>> >>>> On 13-09-29 03:35 AM, Michael Fuckner wrote: >>>>> Hi, >>>>> did you try the driver provided by lsi? It seems to be for FreeBSD >>>>> 9.0, but perhaps it is also working. >>>>> http://www.lsi.com/products/storagecomponents/Pages/LSISAS9300-4i4e >>>>> .a >>>>> spx >>>>> -> >>>>> Support & Downloads -> Driver -> FreeBSD? >>>>> Seems like 12GBit is not supported inbox right now- I am still >>>>> waiting for my 12GBit HBA Card :( Regards, >>>>> Michael! >>>>> >>>>> > Douglas Gilbert hat am 28. September >>>>> 2013 um 22:27 geschrieben: >>>>> > >>>>> > >>>>> > I've noticed that 9.1 does not recognize a LSI 9300-4i4e > SAS >>>>> HBA (relatively new: 12 Gbps). Do any more recent > RCs or betas >>>>> have support for it? >>>>> > >>>>> > Doug Gilbert >>>>> > _______________________________________________ >>>>> > freebsd-scsi@freebsd.org mailing list > >>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >>>>> > To unsubscribe, send any mail to >>>>> "freebsd-scsi-unsubscribe@freebsd.org" >>>> >>> >>> _______________________________________________ >>> freebsd-scsi@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-scsi >>> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" >> >> >> > > > > From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 15:40:17 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3C105BE7 for ; Fri, 4 Oct 2013 15:40:17 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm48.bullet.mail.bf1.yahoo.com (nm48.bullet.mail.bf1.yahoo.com [216.109.114.64]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A79DA24D1 for ; Fri, 4 Oct 2013 15:40:16 +0000 (UTC) Received: from [98.139.212.149] by nm48.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:40:09 -0000 Received: from [98.139.211.194] by tm6.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:40:09 -0000 Received: from [127.0.0.1] by smtp203.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:40:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380901209; bh=pAZ/MdZvJ1akrlI4M0sZvo7MP7ToeopeKxz7J+nKlM0=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=DZC115YfCxlfoi34SU9NW3Njf3zVkkVsdpk+erTySZrYi3L8Kkqcxo2Ac2+5Ysds87c08N1EKl9fmnpZkR5ZONuIrAlOUs/EILAfpNq86ruR/mEYkVztAyVRipmE2ym2oq0Vvi7QCegi1J/oohEE0k5+TiHstIyOzh89Ra/cV8Y= X-Yahoo-Newman-Id: 113716.60954.bm@smtp203.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: X7GgIJUVM1kPqgQY2qhErrhQsZLgx9R0JFHpmFd9HWxr7pf s7EnBXu6ad0r0PeHyUdhyWzNpCAATX39wotGvxRIExeXV5pV53jVZ8aDRcda yIaQfAdCqAkooYmXeBtfCjRi2WAV2Iq6cqHuaIC9XfM10ifg3G2Pj9IoIJtl f7uqBCcmrMhMue0ne5IGaMbdt09sCZj0wfrJGwtt1tPu.kRxDvm8ZDEstra0 aWEtQbr0Q.fqaTi8iyxVrAwC3x3fMUxkFgCVoYAMGODXaJGqXuDwt5YGUgCY DnKApc.HYRqsOB6CwuptTgAAMi9NzZOul3omwr5ExYImhsTklKk2.K6BnxLL KsZymXfG_OJ4lTOcCSnYzYD4kfSP34Pni.5NMNjtBd.VGFyN5vMd9vtLWp4Z QAZxKy1AdkHsimGr29boyR6NX283AJTYUeRLX3krD3Hp_DmsyuKd49jzFuuK CzjY62p9T_4VVMigx8tv5xBD.KR8B8EoMgcxftvb7_aElDi00NxvUwkU9K2v fwsktYcF8hGkIYIAwK1Sjct7zQ4FXSHFDO1KASFZzVtlTHYHBjnXaMLmqdng l5KBR4A83kvDaZWx41eqP8fXvZzjPXAli.BM_NVt6ofpgD7yaU_ai X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.43.121] (sean_bruno@70.197.5.217 with ) by smtp203.mail.bf1.yahoo.com with SMTP; 04 Oct 2013 08:40:09 -0700 PDT Subject: Errors, but nothing fatal from sparc64, 9.2r-ish From: Sean Bruno To: "FreeBSD-scsi@freebsd.org" Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-MQFnKMvb8PCDSo5UbF0W" Date: Fri, 04 Oct 2013 08:40:06 -0700 Message-ID: <1380901206.2621.3.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 15:40:17 -0000 --=-MQFnKMvb8PCDSo5UbF0W Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Noted while debugging a h/w issue on nova.freebsd.org (v480, sparc64), that I'm seeing this error from the FCAL adapter. This seems like a problem, but it doesn't seem to affect anything. > dmesg|grep isp isp0: port 0x300-0x3ff mem 0x400000-0x400fff at device 2.0 on pci3 isp0: invalid NVRAM header isp0: invalid NVRAM header isp0: bad frame length (0) from NVRAM- using 1024 isp0: bad execution throttle of 0- using 16 da0 at isp0 bus 0 scbus1 target 0 lun 0 da1 at isp0 bus 0 scbus1 target 1 lun 0 --=-MQFnKMvb8PCDSo5UbF0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSTuFOAAoJEBkJRdwI6BaHLsYH/RcyozTMO3DGSCdA/rjBtAsF cBNXfNVl/j7orOG/x23X2ggHZKkbzoNxMx9mlSwGoLmZkHYwPNrUKfyZzWSv0lPe GmICVsB/x9s5/WaO4EfiDh/Nhouv3WioWnbz/NW5GMLQANgizJGNxbaVwyxFHOD7 miAizvYgG82kr4XKzphuAgC4OulOiwREVmQRnryB7GPeL2O3b5eIaq1uPr2xQ2ho +I5fSeJOQ3shET1XF57lV+gF5LTDIn6yd/eEv+/9DZknt5ZkTX0cNuOBWkdTWXql 8IXCBX2Lc58YrWyeIQizIoUJa3P6Vnbq5qv+m4P6l5laKYFnq3dNZqKXg01ydK4= =1g+W -----END PGP SIGNATURE----- --=-MQFnKMvb8PCDSo5UbF0W-- From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 15:57:05 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 22D0C344 for ; Fri, 4 Oct 2013 15:57:05 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm26-vm0.bullet.mail.bf1.yahoo.com (nm26-vm0.bullet.mail.bf1.yahoo.com [98.139.213.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C97B25AC for ; Fri, 4 Oct 2013 15:57:04 +0000 (UTC) Received: from [98.139.212.149] by nm26.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:56:57 -0000 Received: from [98.139.213.10] by tm6.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:56:57 -0000 Received: from [127.0.0.1] by smtp110.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 15:56:57 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380902217; bh=Fyz1HTE7PuE5qRBAtttrflycSOlMBQSXbND+eSr0jfo=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=w1ARcjG5Lo7G/BJ6P9TLHgv1NyJQwuY8nu/4P/LfPlmiWidfjmLtGPr47veLXQXum0qf3yIAQLhotXdWxNJLPr4NZEBY1xGY7Dva9F88Jwu1WG+2vJX7vavTDC/k8sPGivnjqlEzmedZ3iZ6PMaJ7JvH0daRyWjOuwYvUzD/+HA= X-Yahoo-Newman-Id: 106223.43477.bm@smtp110.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 24kh.WEVM1l.rV1ELHc6GvkzRjgnTwoA3VVBABCsvUH5XJs u0DIDjUT2HCJ0ItMmL9svf2v7.VwEL8jm3KITN96DAg0YVLjInmewVRtTuGS LfPYVBpFXMfqnWsHXCHpilqr0hpV46dBJYEdfRTOCup5QW0JxMamYcOuCC1V _e55f6Il5vxrp9EsHHJ9FGeJLWEGV2psbr.ifdM.yoAe.AexjHxZdxRezmhG UORDEmo9ibulMpJyMBGTXAQMIUWcxO1bpD1XlA6RXJtUHVGuPWAA9D5Lh29P 5Pj9B7jadI0qHZNhdGfeGF2lIsgug9_yDo6vhqxrSrKph.B_z1.pn5r79kUH PYPwO0AjzJ5wu3x4WJlLU5iMEwHuzRir0ZN0XVQxHhKZTVWYeiVUU5RM3DHW Yy8f7n3p60RoN.BFHNPF_Rq_puwunJcGsG_ljrHB.7b49N1zjVN8CvDNYHIt MqITs.ffblsKalVl2ggiW_1zFaRsE1UeHspvm7Vgk8nOWi4bY742xk14gizZ xD0jCFlgyjIL0uX_vL5Q0xjkyAnQK1I9UcEhi1e0phNCqm0QOFAo- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.43.121] (sean_bruno@70.197.5.217 with ) by smtp110.mail.bf1.yahoo.com with SMTP; 04 Oct 2013 08:56:57 -0700 PDT Subject: pci_alloc_msi is always called, is this bad? From: Sean Bruno To: "FreeBSD-scsi@freebsd.org" In-Reply-To: <20131003194704.GG41229@kib.kiev.ua> References: <20131003194704.GG41229@kib.kiev.ua> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Y0dMsK0bGNdzLsQSS1c9" Date: Fri, 04 Oct 2013 08:56:49 -0700 Message-ID: <1380902209.2621.11.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 15:57:05 -0000 --=-Y0dMsK0bGNdzLsQSS1c9 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I was looking at the recent thread on -stable about mfi(4) and I noted that it appears, if I'm not mistaken, mfi_pci.c::pci_alloc_msi() is *always* invoked regardless of the mfi_msi tuneable. We just ignore the allocated MSI by not setting sc->mfi_irq_rid. Is that harmful? ------------------------------------------------------------------------ 240 /* Allocate IRQ resource. */ 241 sc->mfi_irq_rid =3D 0; 242 count =3D 1; 243 if (mfi_msi && pci_alloc_msi(sc->mfi_dev, &count) =3D=3D 0) { 244 device_printf(sc->mfi_dev, "Using MSI\n"); 245 sc->mfi_irq_rid =3D 1; 246 } ------------------------------------------------------------------------ I would have thought that this would be more correct, avoid calling pci_alloc_msi() if mfi_msi isn't set in the first place. ------------------------------------------------------------------------ sc->mfi_irq_ird =3D 0; count =3D 1; ret =3D 0 if(mfi_msi) ret =3D pci_alloc_msi(sc->mfi_dev, &count); if (!ret) { device_printf(sc->mfi_dev, "Using MSI\n"); sc->mfi_irq_rid =3D 1; } ------------------------------------------------------------------------ Sean --=-Y0dMsK0bGNdzLsQSS1c9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSTuVBAAoJEBkJRdwI6BaHbJMH/jrKGb60hQFcmTC/ETEPeSWx fCoxeT+TsICKXycUAXNyc+0ThndqOwUBBDEN+yEMRn1YwbT4jk4WaM2w6yxLXFf3 0Zixb9K3IMNKIrlNZfVgqvEXty56PHRML/kvvlj0GXmEndKRcgQCEaLr/yEc79lK 4XGrk1oJUoZtXljCZr5OEuRM9TYMkxBDRZZuaIxZigqUO0bVOP2gCna4Q7/ixY2p qH5mtYAoq20YSrnSF71MwerO624TVjrusVMUpVkEoZ9+8Fnd2xO/xy1CzhPgZDwE xeTRINRNTXN8NRdAvwHJHova1DcZdzmF5NOyaXGjc1otmZAqHRvAPHfNJbf5XvU= =6UmQ -----END PGP SIGNATURE----- --=-Y0dMsK0bGNdzLsQSS1c9-- From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 16:05:28 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 86E2479D for ; Fri, 4 Oct 2013 16:05:28 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm16.bullet.mail.bf1.yahoo.com (nm16.bullet.mail.bf1.yahoo.com [98.139.212.175]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D2F372649 for ; Fri, 4 Oct 2013 16:05:27 +0000 (UTC) Received: from [98.139.215.141] by nm16.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:05:20 -0000 Received: from [98.139.211.196] by tm12.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:05:20 -0000 Received: from [127.0.0.1] by smtp205.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:05:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380902720; bh=8g6YzqanxN9j9mkm5MquJLwsAzp2F8mVR78DwGkYAow=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=KtKaecSr9m79jy7Wrc8d2LeA1n5sFdBtsn9MWWW23BR/hWEP542JDdJ3390gW+L9gJCJPZIkly9fNPjZ8GAJjWg5gY0ttDpXlaF7JNXGhKXBMUoHsyK+ifdwnNpohYJO3A9HE79LuWT0k8ijlhr4psJFKhvNTirDuqMJnSRT1IA= X-Yahoo-Newman-Id: 625264.10605.bm@smtp205.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: I8Ue73wVM1m8pyM6dWnw24XNI7dhas6jx9p1UPIZ3nZ.lzl MRZN3NDGNp3hw8L4hapPUdXbGDWPbmfUhSUdLJhkxcwu2389BRP8mQyauN_A WqnroqM3jp2EBu1Bv_T1CaAsW2Sx5XnAm6zAtVhjr6eq7JLTFvVItpsr.CJX uXfocOMTyTF_Ny5KCZtBwyP8M9zK5wK.xUnVySra3d8BwZPukWoBgGQ0ZH75 Qt02iznbmSQX2ZiSiitfso6N3qUprhP6k8sYgj0rgP.BlljGii5JGxZs0C3Z ATanQsRlCSR7uStIiE7k8_ET1z44Io5SCKKgeQ1EiqgjwXKP64uxFWqW8j1p PxTIoSZttBNcXB_Uwb8ik6WCzLC9EbDGBQRrb9ie6quGJ8si7v.oR9nXUraB 2vQ6jrzEM198XZexsetxR4NMXT39eTj7YecG2DF1Hb_RNfE_PIrdX_HWntbY J7XdDfWjq8YHhpVGXzIpO5BvjJD67MmtYpP2YBCPLxsVI0ToQ5BW7cHpSgCL PaJCo3OySLPCzOR7AmivWyeplBwuyXvtfp_Kqz7Qp7HQKOYeUJQsyndA4kw- - X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from lgmac-jluy.corp.netflix.com (scott4long@69.53.237.126 with ) by smtp205.mail.bf1.yahoo.com with SMTP; 04 Oct 2013 09:05:20 -0700 PDT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: pci_alloc_msi is always called, is this bad? From: Scott Long In-Reply-To: <1380902209.2621.11.camel@localhost> Date: Fri, 4 Oct 2013 10:05:18 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> To: sbruno@freebsd.org X-Mailer: Apple Mail (2.1510) Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:05:28 -0000 It used to be that gcc would generate code that would conditionally = execute the second clause only if the first clause were true. If that's = not longer the case (with gcc and/or clang), then I bet that UDF will = break due to this: /* * Check to see if the fid is fragmented. The first test * ensures that we don't wander off the end of the buffer * looking for the l_iu and l_fi fields. */ if (ds->off + UDF_FID_SIZE > ds->size || ds->off + le16toh(fid->l_iu) + fid->l_fi + UDF_FID_SIZE > = ds->size){ =20 Scott On Oct 4, 2013, at 9:56 AM, Sean Bruno wrote: > I was looking at the recent thread on -stable about mfi(4) and I noted > that it appears, if I'm not mistaken, mfi_pci.c::pci_alloc_msi() is > *always* invoked regardless of the mfi_msi tuneable. We just ignore = the > allocated MSI by not setting sc->mfi_irq_rid. Is that harmful? >=20 > = ------------------------------------------------------------------------ > 240 /* Allocate IRQ resource. */ > 241 sc->mfi_irq_rid =3D 0; > 242 count =3D 1; > 243 if (mfi_msi && pci_alloc_msi(sc->mfi_dev, &count) =3D=3D = 0) { > 244 device_printf(sc->mfi_dev, "Using MSI\n"); > 245 sc->mfi_irq_rid =3D 1; > 246 } >=20 >=20 > = ------------------------------------------------------------------------ > I would have thought that this would be more correct, avoid calling > pci_alloc_msi() if mfi_msi isn't set in the first place. > = ------------------------------------------------------------------------ > sc->mfi_irq_ird =3D 0; > count =3D 1; > ret =3D 0 > if(mfi_msi) > ret =3D pci_alloc_msi(sc->mfi_dev, &count); >=20 > if (!ret) { > device_printf(sc->mfi_dev, "Using MSI\n"); > sc->mfi_irq_rid =3D 1; > } > = ------------------------------------------------------------------------ >=20 > Sean From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 16:19:52 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C2F51D9F; Fri, 4 Oct 2013 16:19:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 254112705; Fri, 4 Oct 2013 16:19:51 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r94GJlp3090729; Fri, 4 Oct 2013 19:19:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r94GJlp3090729 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r94GJlGQ090728; Fri, 4 Oct 2013 19:19:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 4 Oct 2013 19:19:47 +0300 From: Konstantin Belousov To: Scott Long Subject: Re: pci_alloc_msi is always called, is this bad? Message-ID: <20131004161947.GU41229@kib.kiev.ua> References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ImgWj/n5mMvZ1QVT" Content-Disposition: inline In-Reply-To: <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:19:52 -0000 --ImgWj/n5mMvZ1QVT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 04, 2013 at 10:05:18AM -0600, Scott Long wrote: > It used to be that gcc would generate code that would conditionally execu= te the second clause only if the first clause were true. If that's not lon= ger the case (with gcc and/or clang), then I bet that UDF will break due to= this: >=20 > /* > * Check to see if the fid is fragmented. The first test > * ensures that we don't wander off the end of the buffer > * looking for the l_iu and l_fi fields. > */ > if (ds->off + UDF_FID_SIZE > ds->size || > ds->off + le16toh(fid->l_iu) + fid->l_fi + UDF_FID_SIZE > ds-= >size){ Is this some sort of joke ? C 'and' and 'or' logical operators are short-circuit. It is not compiler-depended. --ImgWj/n5mMvZ1QVT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iQIcBAEBAgAGBQJSTuqiAAoJEJDCuSvBvK1BpmcP/2jhDRiUqchmjr/iWpJ1Nsbb lIZuwTm+jzd+YV3rmgOHm+HJBX9HkN2jhuRw8lEV0LLw4dpJ39LxbDLcPx+2SX1u lFBzVsIZOObf0d50yqNRofC0sHGrbki2+xV3mEoS1XkLP7W2LN/MdNLpsHo35fOl zQYwfBbeglfT8Lc/ZPbxE/4ViL8RUBL62+dBBw6gwVrkWrNylzO7e5gv0x/CTFcA eT0mtBsswEx4qAo8/hR244vxxAm8eQLjdntGRHPYQj6kwnQwxBg+9NE5IMoA6esT 8fleCrgJIhuBeA/ul1Hz2pDeEj3M7f2cvww3GAKMIQMPppizGRanzYNvMqsL6T08 ZM0RSN7PWPsWIeQktXPO17XvuHkBizIfOESP3ahQVbfZQvRcfsy1+yK4hpawm2/w LPuNEXUrkljeJ34oBPYAzJhQMfNqq1AMsTknpg4TiNMjJtc7jHi3wLcl3FNAMcX/ VlTUk3DumA8yCQ5LOhcldfNaIaOofMK8+JZ8ppxalfis5st32bjeHb0EJzHa5Ndb wZX9ZMJN1ac699DmAXasf7sgTOy2vCUwLGrU6wpG3vNFrshu7c5PKUHnh6ChejnV svSQnVdj1WQnFV4WooH+HFXWydzz+MHJ6YEGsk48IuiHN5TbZpYQ1jE8617Rfjpr atuReiBcAgEXQ6EYCDgw =ZiWM -----END PGP SIGNATURE----- --ImgWj/n5mMvZ1QVT-- From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 16:41:25 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id AA3A0680 for ; Fri, 4 Oct 2013 16:41:25 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm36.bullet.mail.bf1.yahoo.com (nm36.bullet.mail.bf1.yahoo.com [72.30.239.5]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EF1032870 for ; Fri, 4 Oct 2013 16:41:24 +0000 (UTC) Received: from [98.139.212.151] by nm36.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 Received: from [98.139.211.192] by tm8.bullet.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 Received: from [127.0.0.1] by smtp201.mail.bf1.yahoo.com with NNFMP; 04 Oct 2013 16:41:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380904875; bh=eQN8jI0bwagQHt0fwSHAbBb1u3wWX2d2LFRlcydk2sg=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=K4QTXFpZdJSzoHZMAaNpimDEpQNt39nMMX8bokUPPQInav3ckFc5VexSbmFISfj7TZBgQvcqSA48eSqAxH+MS+/0y6QMIni1r1fevCi7Nu1LHSLVrQjzRu/eaqOqbZ4HGVzGBGQPoO7AJj4UgEzo9+GGi/RZoe1GqGgnetgdCwg= X-Yahoo-Newman-Id: 903656.84265.bm@smtp201.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: lG._fNkVM1nR4XdNcZeLziWHELQWNCncsFPhHbpsKaFnKfi 0wgWh3aOMQb7n8xv56WVMEjRQHyUuCTq1F5YckYEPduQZmo3PrKxvo6NaeM4 HzzLMhJWzr2PVxcwWa0xYmf2wFswjyACLnWg3yfWpWE0RprvmfDT8PrA02KX r.sj5_6OCrlTcwJYMBhh1X4zh9uB_i8zN8ttVDIqXKfO2gbElGIPLSepMetF W_AcYdhame66ZWF.pumRxanypPmlMmCJaGyD.nwQ0_rWjTKbkDb0uXt8WJLR .NEma_GcZOziEvadxTW6I1RCuHjlgAXlfvbQEtErbwZ1T0X4CQV5VzVXkksb EIjyxxUYWaHzUdF68aMpA5AMbSqYTLxpB5024w0YLKbUCuyH9DizE380p03x S0GZNVRD1aouzULYPj8aW8TmcRWxCN8nUyRtr85260wp7QB0EufD9mxykeey KrckC6PsFrmYuBv0VL5IRIwvLsWNVgW61dTONbBKyaikCNdq_KJbmTeOPeS5 kXkq0EQ_ax.6oJ.pUXi_s0AQZlNeD9Td48RspHN2saiJ0ijhQ0bumEtl9Rw- - X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from lgmac-jluy.corp.netflix.com (scott4long@69.53.237.126 with ) by smtp201.mail.bf1.yahoo.com with SMTP; 04 Oct 2013 09:41:15 -0700 PDT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: pci_alloc_msi is always called, is this bad? From: Scott Long In-Reply-To: <20131004161947.GU41229@kib.kiev.ua> Date: Fri, 4 Oct 2013 10:41:13 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <80AF177A-215F-49B7-8254-8FD896945849@yahoo.com> References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> <94C7BB39-A287-44D4-9992-E8DAE83CE6D4@yahoo.com> <20131004161947.GU41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:41:25 -0000 On Oct 4, 2013, at 10:19 AM, Konstantin Belousov = wrote: > On Fri, Oct 04, 2013 at 10:05:18AM -0600, Scott Long wrote: >> It used to be that gcc would generate code that would conditionally = execute the second clause only if the first clause were true. If that's = not longer the case (with gcc and/or clang), then I bet that UDF will = break due to this: >>=20 >> /* >> * Check to see if the fid is fragmented. The first test >> * ensures that we don't wander off the end of the buffer >> * looking for the l_iu and l_fi fields. >> */ >> if (ds->off + UDF_FID_SIZE > ds->size || >> ds->off + le16toh(fid->l_iu) + fid->l_fi + UDF_FID_SIZE > = ds->size){ > Is this some sort of joke ? >=20 > C 'and' and 'or' logical operators are short-circuit. It is not > compiler-depended. Meh, I was young and stupid. The generated code supported the = construct. Scott From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 16:57:02 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D07DCE61; Fri, 4 Oct 2013 16:57:02 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 93E792931; Fri, 4 Oct 2013 16:57:02 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r94Gv1Vd030527 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Oct 2013 09:57:01 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r94Gv1CP030526; Fri, 4 Oct 2013 09:57:01 -0700 (PDT) (envelope-from jmg) Date: Fri, 4 Oct 2013 09:57:01 -0700 From: John-Mark Gurney To: sbruno@freebsd.org Subject: Re: pci_alloc_msi is always called, is this bad? Message-ID: <20131004165701.GJ56872@funkthat.com> Mail-Followup-To: John-Mark Gurney , sbruno@freebsd.org, "FreeBSD-scsi@freebsd.org" References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1380902209.2621.11.camel@localhost> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 04 Oct 2013 09:57:01 -0700 (PDT) Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 16:57:02 -0000 Sean Bruno wrote this message on Fri, Oct 04, 2013 at 08:56 -0700: > I was looking at the recent thread on -stable about mfi(4) and I noted > that it appears, if I'm not mistaken, mfi_pci.c::pci_alloc_msi() is > *always* invoked regardless of the mfi_msi tuneable. We just ignore the > allocated MSI by not setting sc->mfi_irq_rid. Is that harmful? > > ------------------------------------------------------------------------ > 240 /* Allocate IRQ resource. */ > 241 sc->mfi_irq_rid = 0; > 242 count = 1; > 243 if (mfi_msi && pci_alloc_msi(sc->mfi_dev, &count) == 0) { > 244 device_printf(sc->mfi_dev, "Using MSI\n"); > 245 sc->mfi_irq_rid = 1; > 246 } > > > ------------------------------------------------------------------------ > I would have thought that this would be more correct, avoid calling > pci_alloc_msi() if mfi_msi isn't set in the first place. > ------------------------------------------------------------------------ > sc->mfi_irq_ird = 0; > count = 1; > ret = 0 > if(mfi_msi) > ret = pci_alloc_msi(sc->mfi_dev, &count); > > if (!ret) { > device_printf(sc->mfi_dev, "Using MSI\n"); > sc->mfi_irq_rid = 1; > } > ------------------------------------------------------------------------ Per C99 6.5.13 Logical AND operator, para 4: Unlike the bitwise binary & operator, the && operator guarantees left-to-right evaluation; there is a sequence point after the evaluation of the first operand. If the first operand compares equal to 0, the second operand is not evaluated. So the above two code blocks are logically equivalent... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 17:01:22 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3FF29116 for ; Fri, 4 Oct 2013 17:01:22 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm25-vm2.bullet.mail.gq1.yahoo.com (nm25-vm2.bullet.mail.gq1.yahoo.com [98.136.217.113]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F12E6297D for ; Fri, 4 Oct 2013 17:01:21 +0000 (UTC) Received: from [216.39.60.184] by nm25.bullet.mail.gq1.yahoo.com with NNFMP; 04 Oct 2013 17:01:15 -0000 Received: from [208.71.42.200] by tm20.bullet.mail.gq1.yahoo.com with NNFMP; 04 Oct 2013 17:01:15 -0000 Received: from [127.0.0.1] by smtp211.mail.gq1.yahoo.com with NNFMP; 04 Oct 2013 17:01:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1380906075; bh=OGH4yXchHF9kXK9RbecDahsp1UAT23tNUWqI8tp0T3c=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=ee31uFYBeBgUOcCr0pfNHXGaPQw+BYBIgpMjq6mQsUY3iT5SuC2mX10LZyJKqJP8p1Z3FOYp5wddVoTKFZGlrUu9DRM9fr5sM/90SdY2Pc197mxD3jJqKpgYXaMvcX5yuW4JNHeJgTAwkCNUmdhvoXSSzAp9pghb42cKLjLm+e4= X-Yahoo-Newman-Id: 915482.30297.bm@smtp211.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: YErCeZIVM1nYngUvVF8r7NcCjdKKRD8Pg.I.VuQHhFm8qqA x6Is9c_qQDICBzuCxDMnnLv1jfidE9o.AJxxakldPLR.q6oG8enqZZB2D1Pz HHRuzZraS9gFqegfa6ZNM6UCQIJ4wz_acFxBSTYX20E7YAkHNd2psgBl7VsB 41wHkZhAh0OcmbLY8w6TonEoyBgbcu8Y4UuyyxPhzTe5xNxuQNXQeqRAn1XM VvbSlDqZZG4B3lGJxsJyYfcYl6dLh4e9eHCU4KFJfJysISX.hS2f2tLdcibO fYXNEvgew9c9QYWt302tu40aHVd3VwOkWiv8j_FG5ONkLrUZXPnSm2iQ3GOC f6iBIO1CBGBgKHVkI8jA2P.ewsO7U.2YelLLnY.VAkkZD5mm7QLKJYo64dnE kOZ30Ud0spRH8yUGyIR01pF5sjoj26iFUzwiMbNdBzGLntbzLPWJlDxrpIZU 38ElRwPPDJ5JkMBDdDq0HLyHPNseds3klrT2neLwqzHb777gNqjtDcxiP1bO fVuOvY5NxrFjgNrpIwf6sw5v7aGoUEMftPyQl7u4YlOBojMfw7ThCTZkH X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.43.121] (sean_bruno@70.197.5.217 with ) by smtp211.mail.gq1.yahoo.com with SMTP; 04 Oct 2013 10:01:14 -0700 PDT Subject: Re: pci_alloc_msi is always called, is this bad? [never mind] From: Sean Bruno To: sbruno@freebsd.org In-Reply-To: <1380902209.2621.11.camel@localhost> References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-PoqG66kFQ3mtexPQW068" Date: Fri, 04 Oct 2013 10:01:12 -0700 Message-ID: <1380906072.2915.2.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 17:01:22 -0000 --=-PoqG66kFQ3mtexPQW068 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Fri, 2013-10-04 at 08:56 -0700, Sean Bruno wrote: > I was looking at the recent thread on -stable about mfi(4) and I noted > that it appears, if I'm not mistaken, mfi_pci.c::pci_alloc_msi() is > *always* invoked regardless of the mfi_msi tuneable. We just ignore the > allocated MSI by not setting sc->mfi_irq_rid. Is that harmful? >=20 > ------------------------------------------------------------------------ > 240 /* Allocate IRQ resource. */ > 241 sc->mfi_irq_rid =3D 0; > 242 count =3D 1; > 243 if (mfi_msi && pci_alloc_msi(sc->mfi_dev, &count) =3D=3D 0) { > 244 device_printf(sc->mfi_dev, "Using MSI\n"); > 245 sc->mfi_irq_rid =3D 1; > 246 } >=20 >=20 > ------------------------------------------------------------------------ > I would have thought that this would be more correct, avoid calling > pci_alloc_msi() if mfi_msi isn't set in the first place. > ------------------------------------------------------------------------ > sc->mfi_irq_ird =3D 0; > count =3D 1; > ret =3D 0 > if(mfi_msi) > ret =3D pci_alloc_msi(sc->mfi_dev, &count); >=20 > if (!ret) { > device_printf(sc->mfi_dev, "Using MSI\n"); > sc->mfi_irq_rid =3D 1; > } > ------------------------------------------------------------------------ >=20 > Sean Ah, ok. so, no, this is just me not understanding C. Wrote a small test to see what kib and scott were chatting about and the conditional && does indeed short circuit if the first condition is false. Good to know. Carry on! #include #include int test() { int j =3D 1; printf ("test is running\n"); return j; } int main (int argc, char **argv) { int i =3D atoi(argv[1]); printf ("i %d\n", i); if ( i && test() ) printf ("both are true\n"); return 0; } --=-PoqG66kFQ3mtexPQW068 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSTvRQAAoJEBkJRdwI6BaHSrsH/2r6sTKIXqVoohlSFScWLWvT 75vDpTN0y0IkM8TtbmSUombaIt8M6GTaKumruaWFUgCUDIhz3OveytdckN/zCO1S rmxnyCrCvYr/ttfoGHz5SOURSPbfeZM5PX4CiiRgjsgwOa8+mFfVqQVs5RbB5nwB /sYbfvdnP5m9rNVSXOuXv3lJ5LyORoxkxT0vUfOF8fsymrsMB/IcsS4kP2tFWjT5 nNRZLZHIyKH+WoIi+uF7GuQia2nb1LVNrCRw3zL5zL1cBAwT0MHTTlCleMz8nibU yt+qKu0xI3iCvb1m5Y6C3HopS86oPkdFBUdDkmTCiZXLSJOLmluNNOdeXPQvyrI= =kr8+ -----END PGP SIGNATURE----- --=-PoqG66kFQ3mtexPQW068-- From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 21:59:48 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4DB9EA0C; Fri, 4 Oct 2013 21:59:48 +0000 (UTC) (envelope-from dgilbert@interlog.com) Received: from smtp.infotech.no (smtp.infotech.no [82.134.31.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0B21C293F; Fri, 4 Oct 2013 21:59:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.infotech.no (Postfix) with ESMTP id 22CC520423A; Fri, 4 Oct 2013 23:59:39 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.6 (20110518) (Debian) at infotech.no Received: from smtp.infotech.no ([127.0.0.1]) by localhost (smtp.infotech.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k+w-ASAxYC8i; Fri, 4 Oct 2013 23:59:38 +0200 (CEST) Received: from [10.7.0.30] (unknown [10.7.0.30]) by smtp.infotech.no (Postfix) with ESMTPA id 3DBB52041D0; Fri, 4 Oct 2013 23:59:37 +0200 (CEST) Message-ID: <524F3A2A.2010700@interlog.com> Date: Fri, 04 Oct 2013 17:59:06 -0400 From: Douglas Gilbert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: John-Mark Gurney , sbruno@freebsd.org, "FreeBSD-scsi@freebsd.org" Subject: Re: pci_alloc_msi is always called, is this bad? References: <20131003194704.GG41229@kib.kiev.ua> <1380902209.2621.11.camel@localhost> <20131004165701.GJ56872@funkthat.com> In-Reply-To: <20131004165701.GJ56872@funkthat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dgilbert@interlog.com List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 21:59:48 -0000 On 13-10-04 12:57 PM, John-Mark Gurney wrote: > Sean Bruno wrote this message on Fri, Oct 04, 2013 at 08:56 -0700: >> I was looking at the recent thread on -stable about mfi(4) and I noted >> that it appears, if I'm not mistaken, mfi_pci.c::pci_alloc_msi() is >> *always* invoked regardless of the mfi_msi tuneable. We just ignore the >> allocated MSI by not setting sc->mfi_irq_rid. Is that harmful? >> >> ------------------------------------------------------------------------ >> 240 /* Allocate IRQ resource. */ >> 241 sc->mfi_irq_rid = 0; >> 242 count = 1; >> 243 if (mfi_msi && pci_alloc_msi(sc->mfi_dev, &count) == 0) { >> 244 device_printf(sc->mfi_dev, "Using MSI\n"); >> 245 sc->mfi_irq_rid = 1; >> 246 } >> >> >> ------------------------------------------------------------------------ >> I would have thought that this would be more correct, avoid calling >> pci_alloc_msi() if mfi_msi isn't set in the first place. >> ------------------------------------------------------------------------ >> sc->mfi_irq_ird = 0; >> count = 1; >> ret = 0 >> if(mfi_msi) >> ret = pci_alloc_msi(sc->mfi_dev, &count); >> >> if (!ret) { >> device_printf(sc->mfi_dev, "Using MSI\n"); >> sc->mfi_irq_rid = 1; >> } >> ------------------------------------------------------------------------ > > Per C99 6.5.13 Logical AND operator, para 4: > Unlike the bitwise binary & operator, the && operator guarantees > left-to-right evaluation; there is a sequence point after the > evaluation of the first operand. If the first operand compares equal > to 0, the second operand is not evaluated. The C Programming Language, Kernighan and Ritchie, Copyright 1978. See the middle of page 38. After explaining this feature they say: "These properties are critical to writing programs that work." BTW the book was phototypeset "by a PDP 11/70 running under the Unix operating system". From owner-freebsd-scsi@FreeBSD.ORG Fri Oct 4 22:59:43 2013 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 46FB2AF8 for ; Fri, 4 Oct 2013 22:59:43 +0000 (UTC) (envelope-from mjacob@freebsd.org) Received: from virtual.feral.com (virtual.feral.com [216.224.170.83]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0EF792BFB for ; Fri, 4 Oct 2013 22:59:42 +0000 (UTC) Received: from [192.168.136.3] (lowell.feral.com [76.14.48.84]) by virtual.feral.com (8.14.4/8.14.4) with ESMTP id r94Mwejf010232 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 4 Oct 2013 15:58:41 -0700 Message-ID: <524F4821.3050308@freebsd.org> Date: Fri, 04 Oct 2013 15:58:41 -0700 From: Matthew Jacob Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: freebsd-scsi@freebsd.org Subject: Re: Errors, but nothing fatal from sparc64, 9.2r-ish References: <1380901206.2621.3.camel@localhost> In-Reply-To: <1380901206.2621.3.camel@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (virtual.feral.com [216.224.170.83]); Fri, 04 Oct 2013 15:58:42 -0700 (PDT) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: mjacob@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 22:59:43 -0000 On 10/4/2013 8:40 AM, Sean Bruno wrote: > Noted while debugging a h/w issue on nova.freebsd.org (v480, sparc64), > that I'm seeing this error from the FCAL adapter. This seems like a > problem, but it doesn't seem to affect anything. > >> dmesg|grep isp > isp0: port 0x300-0x3ff mem > 0x400000-0x400fff at device 2.0 on pci3 > isp0: invalid NVRAM header > isp0: invalid NVRAM header > isp0: bad frame length (0) from NVRAM- using 1024 > isp0: bad execution throttle of 0- using 16 > da0 at isp0 bus 0 scbus1 target 0 lun 0 > da1 at isp0 bus 0 scbus1 target 1 lun 0 > Long known problem. The Sun folks have a different layout for NVRAM than QLogic. Neither are well documented. Que lastima. You should probably be ok.