From owner-svn-ports-head@freebsd.org Wed Jul 15 09:41:18 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0027835FA9D for ; Wed, 15 Jul 2020 09:41:17 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B6C7d1pPsz4Xq7 for ; Wed, 15 Jul 2020 09:41:16 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-pf1-x441.google.com with SMTP id t11so1838944pfq.11 for ; Wed, 15 Jul 2020 02:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=zJ8rOKOQ9d5n17YUC1GZALM1NNDD5fA2sRLI3RAm1pw=; b=YxZ0Z8I9JquxeTFmGOY1LDDARpoCpsKSrTxqt855/Fhucj2c7YcdRvrfAxYA4y+d+5 wgl/mwKAdpD6JAAUAzHqTe/MVNu15fjeIGVxje4TRn3IlUTkoA4uzCyOH5yrmg/CGfMz p1M+uj5ZyTYT/RNkw0mcJd5C4jvLul+ES3vAEgQChkRQzjaKYSm2DtOQs0252Ae7eNcf w6HvnAiEelGRx91ehxDID4wJA5Q208Nkl/7jZLuXzAoeltKXSVFTaaGNj7JM5aHmeEoT 87GAkOHlhZiDzXzqDsf+KFmzZ29QfUNzP8y7KyCitrejKrEhzDynHN7cXjfQZM1dmq8p 88Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=zJ8rOKOQ9d5n17YUC1GZALM1NNDD5fA2sRLI3RAm1pw=; b=Lirxy3oO37CkL2C7V6kAM7q2Sa38gbe76D9luHKHjzsqk7IgHOHUZvMldK5WapiYjK qdxL82fO06TwWi6i0bAreTX2O7oxBSSDhi64iYmaaIDYKQI9/zWyY4YA+FMm6q1ODWZD cFBAJNwGuuRNRE4xMx4K8YheYcmVSeGr+qFUVNlPLtZDu0iTT1fdnqr2ITtN5xw8sevt eN2vgsD5qFSkJCk1tLwUKK5Y7ZfQr2LAvg4dZHgZwHmPIekRELTO/91YgAywp5ohHx+P aRDh1g3D0P4hwiUsCST1+ipoYCVfwS3iWqANn97j1qaBekhmSWdJIwvPwWAFHxb1a9Pk iCww== X-Gm-Message-State: AOAM532ap6DwAsA4K0ohxoPtN06LFgfgUdOeAYThYU6SYjlrTuRqOa90 o0dI0OqquDW/2dbcwsGw9jC4SrX8BRs= X-Google-Smtp-Source: ABdhPJyyEdoket9tUj23bpO9yN5mkUNPT+tukPJqk3HATsHSDmCIAiGsMiPyDgZtmX+Kq6gSbYW56A== X-Received: by 2002:a63:d848:: with SMTP id k8mr7070225pgj.119.1594799783925; Wed, 15 Jul 2020 00:56:23 -0700 (PDT) Received: from [10.175.0.30] ([45.56.150.68]) by smtp.gmail.com with ESMTPSA id s6sm1299388pfd.20.2020.07.15.00.56.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 00:56:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Adam Weinberger Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r542249 - in head: devel/msgpack math/calc security/gnupg security/gnupg1 sysutils/z Date: Wed, 15 Jul 2020 01:56:22 -0600 Message-Id: <0E681F2E-7A59-4A0C-9010-35D3E0791C5E@adamw.org> References: <20200715073243.GA31163@FreeBSD.org> Cc: Adam Weinberger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org In-Reply-To: <20200715073243.GA31163@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: iPad Mail (17F80) X-Rspamd-Queue-Id: 4B6C7d1pPsz4Xq7 X-Spamd-Bar: ++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=YxZ0Z8I9; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2607:f8b0:4864:20::441 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [6.12 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(5.00)[45.56.150.68:received]; R_DKIM_ALLOW(0.00)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.15)[0.153]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-head@freebsd.org]; DMARC_NA(0.00)[adamw.org]; NEURAL_SPAM_MEDIUM(0.42)[0.416]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.06)[0.055]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::441:from]; GREYLIST(0.00)[pass,body]; RCVD_TLS_ALL(0.00)[] X-Spam: Yes X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 09:41:18 -0000 > On Jul 15, 2020, at 01:32, Alexey Dokuchaev wrote: >=20 > =EF=BB=BFOn Wed, Jul 15, 2020 at 07:28:28AM +0000, Adam Weinberger wrote: >> New Revision: 542249 >> URL: https://svnweb.freebsd.org/changeset/ports/542249 >>=20 >> Log: >> Unmute some build commands >>=20 >> @@ -30,7 +30,7 @@ USE_GCC=3D yes >>=20 >> post-patch: >> # GoogleTest doesn't support C++98 consumers since 1.10.0 >> - @${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt >> + ${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt >=20 > This is not the build, this is patch command. In the ports, patching > traditionally happens silently. >=20 >> post-install: >> - @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ >> + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ >> ${STAGEDIR}${PREFIX}/lib/lib*.so >=20 > Stripping also typically happens silenty. >=20 >> - @${TOUCH} ${WRKSRC}/doc/*.texi >> + ${TOUCH} ${WRKSRC}/doc/*.texi >=20 > Touching dummy files (cookies) definitely should happen silently. >=20 >> post-install: >> - @${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} >> + ${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} >=20 > This one is correct. >=20 >> post-install-DOCS-on: >> - @${MKDIR} ${STAGEDIR}${DOCSDIR} >> + ${MKDIR} ${STAGEDIR}${DOCSDIR} >>=20 >> do-install: >> - @${MKDIR} ${STAGEDIR}${DATADIR} >> + ${MKDIR} ${STAGEDIR}${DATADIR} >=20 > We usually mute mkdir's. Please do not "fix" what ain't broken, this > just creates needless repochurn, pessimizes "svn blame" and solves > no real problem, but just makes things less consistent throughout the > ports tree. No. Just because we all drew an arbitrary line in the sand at one point does= not make it viable today. Those distinctions were made a long time ago when= (a) everybody who wanted third-party software had to experience it; (b) end= -users had to trouble-shoot build failures (in which case minimizing output w= as critical); and (c) we wanted the building/installing experience to be cle= an and quiet and simple. Now it is far more useful for ports to show exactly what it=E2=80=99s doing.= As an example, your =E2=80=9Cdefinitely should happen silently=E2=80=9D exa= mple is a case where we do something that explicitly causes the build to reg= enerate something that it wouldn=E2=80=99t normally. =E2=80=9CConsistency=E2=80=9D when each build output is completely different= is not a particularly compelling argument for me. It used to be, but now I=E2= =80=99m much more interested in preserving build output whenever possible. # Adam =E2=80=94 Adam Weinberger adamw@adamw.org https://www.adamw.org=