From owner-svn-src-all@FreeBSD.ORG Sun Jan 18 14:49:18 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D3291065672; Sun, 18 Jan 2009 14:49:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id E27A68FC25; Sun, 18 Jan 2009 14:49:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LOYxg-000Oru-5c; Sun, 18 Jan 2009 16:49:16 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n0IEnD9S089982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Jan 2009 16:49:13 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n0IEnD5d088915; Sun, 18 Jan 2009 16:49:13 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n0IEnDmZ088914; Sun, 18 Jan 2009 16:49:13 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 18 Jan 2009 16:49:13 +0200 From: Kostik Belousov To: Stanislav Sedov Message-ID: <20090118144913.GU48057@deviant.kiev.zoral.com.ua> References: <200901181404.n0IE4uXw075698@svn.freebsd.org> <20090118140644.GT48057@deviant.kiev.zoral.com.ua> <20090118174357.3ed1459d.stas@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PhxIMoEr374zxJm2" Content-Disposition: inline In-Reply-To: <20090118174357.3ed1459d.stas@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LOYxg-000Oru-5c 9b513c07f8f0f33d16434a4855b12a18 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187395 - head/sys/gnu/fs/ext2fs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jan 2009 14:49:18 -0000 --PhxIMoEr374zxJm2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 18, 2009 at 05:43:57PM +0300, Stanislav Sedov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On Sun, 18 Jan 2009 16:06:44 +0200 > Kostik Belousov mentioned: >=20 > >=20 > > Please see a discussion on the fs@ and reasoning why I declined to comm= it > > the similar patch. > >=20 >=20 > I'm sorry I've missed that discussion entirely, but I can admit I had all= the > same concerns while reviewing the patch, and Alex's comments and Linux co= de > reading made me fully confident that the modifications are safe and corre= ct. > Let me explain why I think so. >=20 > The extra size added in inodes are used to store additional info like ext= ended > attributes, ACLs and so on. Each inode now has a field just after the leg= acy > inode format struct that shows hom much additional space has been added to > this particular inode. By analyzing this field the operating system can i= nterpret > additional data located in inode, if it understand its format (there migh= t be > application and/or OS specific data too). >=20 > Our implementation just ignore this additional fields after sizeof(ext2fs= _inode), > both while reading and writing. Thus we don't interet this data yet we do= n't > overwrite it. =20 Then, it is ok if you did read the code and became assured that ignoring the additional inode data is safe. In any case, consider yourself an appointed ext2fs maintainer onward. --PhxIMoEr374zxJm2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklzQWgACgkQC3+MBN1Mb4hvgwCeLfZnxjThRBzNLf5IPCOu8AFH HQUAnR4R3/wHWRa4G3KKmwWLFzjCfKxb =lPTr -----END PGP SIGNATURE----- --PhxIMoEr374zxJm2--