Date: Thu, 30 Mar 2017 01:46:20 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: =?utf-8?Q?Roger_Pau_Monn=C3=A9?= <royger@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r316140 - stable/10/sys/dev/xen/netfront Message-ID: <DE3FF998-EED2-4BF8-8378-CF9AA87CF2BC@gmail.com> In-Reply-To: <20170330083631.dtututkocx3t24pb@dhcp-3-128.uk.xensource.com> References: <201703291534.v2TFYq2j041847@repo.freebsd.org> <4E2E5DD5-58CB-4847-8E7A-CCF6734E8904@gmail.com> <20170330083631.dtututkocx3t24pb@dhcp-3-128.uk.xensource.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1D751DCE-B533-4FA3-8A58-66D0B7681450 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 > On Mar 30, 2017, at 01:36, Roger Pau Monn=E9 <royger@FreeBSD.org> = wrote: >=20 > On Wed, Mar 29, 2017 at 10:12:23AM -0700, Ngie Cooper (yaneurabeya) = wrote: >>=20 >>> On Mar 29, 2017, at 08:34, Roger Pau Monn=E9 <royger@FreeBSD.org> = wrote: >>>=20 >>> Author: royger >>> Date: Wed Mar 29 15:34:52 2017 >>> New Revision: 316140 >>> URL: https://svnweb.freebsd.org/changeset/base/316140 >>>=20 >>> Log: >>> xen/netfront: release resources on removal >>>=20 >>> Current netfront code doesn't release the resources (grants and = mbufs) on >>> removal. Add a new helper that releases the resources, so FreeBSD = doesn't run >>> out of grants or memory when performing heavy hotplug/unplug of Xen = PV nic >>> devices. >>>=20 >>> This is a direct commit to stable/10 because the code in newer = branches has >>> been completely refactored and no longer has this issue. >>>=20 >>> Reviewed by: royger >>> Submitted by: Ouyangzhaowei <ouyangzhaowei@huawei.com> >>> Differential review: https://reviews.freebsd.org/D10088 >>=20 >> Hi Roger, >> This broke GENERIC/i386 with a -Wformat warning, but was fixed = in r316170. >=20 > Sight. It was supposedly "thoroughly tested". Sorry for the breakage = and thanks > for the fix! Np! I just wanted to make sure you were aware of the change, in the = event that it needed to work its way back into the vendor tree. Thanks! -Ngie --Apple-Mail=_1D751DCE-B533-4FA3-8A58-66D0B7681450 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY3MXdAAoJEPWDqSZpMIYVdnoP+gN+ulx2jrK4GoV8HpihMImf ByKyIk/tvQoQbD5Ki25UiSfzhnowqBR6TLdpAUIsMX7A69mhjNdfGhwDMafn+lbb tjxFKqpET/6cuUeNG7GKTcjrB1xAgEAOrYp4fbGirujnqbFxOiay4LDwlG4tbbaP Pe37CW9LDhVLm7yhJUKF50YQ9qYb8w3YvQp2Zf/rI5FLYIHbSEfXJGMF468wsJMo okdz6wtrnh3xeylewEgmNr9nzDbcLFj9169WhNstl/TWE1P/GnL2sBxrVM+CABkm eMPWi6kDHXj4nYzXb6xU3GTWQI2tlNcJZlFmmjoSlXaEoUOpZeRtfaNpdXiV8Csp db7Ly8uXtzuVqLLFuJIlncQOY91vmztVFdZHQAyfOfa8jdxb1LhQ8BvNFRC6BUeb v5LyGUbUeUsJ6RoyNwDQc8aMqhyO30UfjXWdfLjOJx+56LxknxKZGkBaU/YxBCep BDIY1+53GmDY//vHJmzWPtesYuU8m8X1cg9SV+OGIXRUaZjgP9FyvKGjqsdAoj+e eR+E2uDpT1goePpmpnVaxBvc+8jiPPSHh4WcOeUCtlDvuwbcdcOfk/IWvqhU6PIe 9b3k/d1hHnKlDba94FKkiLd/5kewsjWG/mDzXV0y255x07qOH0E1SnBKdweQotOq jAql6Z0ZGyWamwOhAYqz =gBzZ -----END PGP SIGNATURE----- --Apple-Mail=_1D751DCE-B533-4FA3-8A58-66D0B7681450--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DE3FF998-EED2-4BF8-8378-CF9AA87CF2BC>