Date: Thu, 22 Feb 2007 15:42:39 +0000 From: "Bruce M. Simpson" <bms@FreeBSD.org> To: "Christian S.J. Peron" <csjp@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <45DDB9EF.50201@FreeBSD.org> In-Reply-To: <200702221450.l1MEoV0O007216@repoman.freebsd.org> References: <200702221450.l1MEoV0O007216@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Christian S.J. Peron wrote: > Use ETHER_BPF_MTAP() instead of BPF_MTAP() here. It's possible > incoming packets have had their 802.1Q tags processed by the > hardware, resulting in them being stripped from the packets, and > placed on the mbuf. This fixes the processing of 802.1Q tags when > hardware offload of 802.1Q tags is enabled. > Thanks for this change. I have integrated it into my local checkout containing the 802.1p/q rewrite as it is needed there to do the right thing when M_VLANTAG is *always* used even when the cards themselves do not do VLAN hwtagging. I have moved the 802.1p/q decapsulation to ether_input() itself as per thompsa@'s suggestion. I should really use p4 (or Hg) for this next time around... BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45DDB9EF.50201>