Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 May 2001 02:19:46 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        "Brian F. Feldman" <green@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/crypto/openssh ssh_config
Message-ID:  <20010525021945.F9388@dragon.nuxi.com>
In-Reply-To: <200105250454.f4P4s0u98061@green.bikeshed.org>; from green@FreeBSD.org on Fri, May 25, 2001 at 12:54:00AM -0400
References:  <obrien@FreeBSD.org> <200105250454.f4P4s0u98061@green.bikeshed.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 25, 2001 at 12:54:00AM -0400, Brian F. Feldman wrote:
> > I don't understand what you are trying to say.
> 
> You can see that the way I had it was consistent with the CURRENT OpenBSD 
> style.

That is nice, but that is NOT _our_ style.  If you diff 1.7 with 1.8,
you'll see you changed the $FreeBSD$ formatting, which you should not
have done.

 
> > BTW, could you not change the style of the vendor tags?  You used
> > "OpenSSH_2_9", while every other vendor tag is v_<version>_<date>
> 
> I'm not importing except the EXACT OpenSSH releases, so the date is 
> redundant.  The vendor itself is OpenBSD, and the exact thing imported is 
> _OpenSSH_ version 2.9, not _OpenBSD_ version 2.9.

You miss the point of _consistancy_.  I hate the way some of the vendor
tags were done on stuff I maintain, but I keep the style to same as it is
easier to notice when doing a `cvs log' and that if I want to diff with a
partitular vendor version, once I know the format used in general, I know
the format for any tag.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010525021945.F9388>