Date: Thu, 6 Aug 2015 03:07:33 +0000 From: Glen Barber <gjb@FreeBSD.org> To: "K. Macy" <kmacy@freebsd.org> Cc: Pawel Jakub Dawidek <pjd@freebsd.org>, Andriy Gapon <avg@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Xin Li <delphij@delphij.net> Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20150806030733.GI1484@FreeBSD.org> In-Reply-To: <CAHM0Q_OHO6tyx3AyyDpMtD7mYeizpW-cLn68dDmdZhwKaQRCVQ@mail.gmail.com> References: <201507020832.t628W3WJ002944@repo.freebsd.org> <CAHM0Q_OcLqT_VuxmL4tFrDyEhAEprm_ivP8j_mrow6ZG1FLcsg@mail.gmail.com> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> <20150806022247.GG1484@FreeBSD.org> <CAHM0Q_OHO6tyx3AyyDpMtD7mYeizpW-cLn68dDmdZhwKaQRCVQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Er/3qITiDpnrteFh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: > On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber <gjb@freebsd.org> wrote: > > On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: > >> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: > >> > On 30/07/2015 10:24, K. Macy wrote: > >> > > Just FYI this change introduces a deadlock with with the > >> > > spa_namespace_lock. Mount will be holding this lock while trying to > >> > > acquire the spa_namespace_lock. zfskern on the other hand holds the > >> > > spa_namespace_lock when calling zfs_freebsd_access which in turn > >> > > tries to acquire the teardown lock. > >> > > >> > I missed the fact that zpool.cache file is being written with spa_na= mespace_lock > >> > held. > >> > I'll try to either resolve the problem in the next day or I will rev= ert the change. > >> > >> FYI, I'm hitting this deadlock on my laptop. Reverting the change fixes > >> the problem. > >> > > > > Since it is now 3 days after "I'll try to either resolve the problem in > > the next day or I will revert the change", my view is that this needs to > > be reverted now, if it hasn't been done already. > > > His proposed solution looks fine to me. Why don't we commit that? >=20 I must have missed the solution - was it part of this thread? If a solution exists, then yes, that should be the fix instead. Glen --Er/3qITiDpnrteFh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVws91AAoJEAMUWKVHj+KTe4kQAIZS2vdbkuC9Yy35s7/iLXg3 Ld2xCo6mvJD71/oRdRCZZSP0ZLHay29jxgQoar8wpli5iu8RNReqlxS+KLfsTZcK pqC6+QZc9euF+gFcSkR9HGh8YmWf++8eOmPnp4DddSKzVnOcbIYg7EAw8BB60E1P qWS9KPMA872XiREYG0jm3BBZ7yXfDoha3UAujk8HUwjkVLhly47OWCVqZDi/q3Td vq5Q5BR7eIvdSViBZhj9zl4OLEbQMs0jnqkQQ6chPX/eWN6oFKCrvwpZgPHAGKqO xtUKt+7HsQxzg3jTdqUTxpGhF4vaDZXmET4MpiHM7a96efvoKkW3AgUn8/r2/Zmg GMD0DI/MajEDdmxkFzM5i3UNroLLxV3eea4SAPboJZ0htTxUyxSA3zhTt8mHjft+ z7qeFaHjUnxzNrL3G0y06FQd100vwmZjL3edWIHn9z7XyFMo32uyISSiYxlCzyes id4ADzHVZPucIH9Km8mKq+DwLI0/liP0FDdBwLm860Eg9xMfEbnEo0e9DmqsvEkH ju8onU0VxSwMVqLYQTQyBtOoO0TB906MNjfhY9Jfijj32MldRu/kQ49HUEARZw23 pC3z0hbX5UieLAX4bMPolYrgc/jlqoegDtq44jzppK9EOPwi00fAtp/BwzD+pmMf eSzUQnZ+bFr++wZszki7 =MerD -----END PGP SIGNATURE----- --Er/3qITiDpnrteFh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150806030733.GI1484>