Date: Fri, 9 Jul 2004 14:43:57 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/pseudofs pseudofs_vnops.c Message-ID: <20040709214357.GZ95729@elvis.mu.org> In-Reply-To: <200407091143.i69Bhbvt053927@repoman.freebsd.org> References: <200407091143.i69Bhbvt053927@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smorgrav <des@FreeBSD.org> [040709 04:43] wrote: > des 2004-07-09 11:43:37 UTC > > FreeBSD src repository > > Modified files: > sys/fs/pseudofs pseudofs_vnops.c > Log: > Accumulate directory entries in a fixed-length sbuf, and uiomove them in > one go before returning. This avoids calling uiomove() while holding > allproc_lock. > > Don't adjust uio->uio_offset manually, uiomove() does that for us. > > Don't drop allproc_lock before calling panic(). I would suggest dropping it. (but I may be wrong). > Suggested by: alfred thanks! :) Also, the routines for inode allocation in psuedofs are very useful, is there some way I can convince you to make them available as a resource for other synthetic filesystems? Perhaps split it out into another module that psuedofs can depend on so that other fs's can use them? thank you, -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040709214357.GZ95729>