Date: Tue, 10 Feb 2004 11:48:42 +0100 From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/62627: [PATCH] bsd.port.mk: PORTDOCS does not work on older systems Message-ID: <4028B70A.8060402@fillmore-labs.com> Resent-Message-ID: <200402101050.i1AAoDKO030498@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 62627 >Category: ports >Synopsis: [PATCH] bsd.port.mk: PORTDOCS does not work on older systems >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Feb 10 02:50:13 PST 2004 >Closed-Date: >Last-Modified: >Originator: Oliver Eikemeier >Release: FreeBSD 5.1-CURRENT i386 >Organization: Fillmore Labs - http://www.fillmore-labs.com >Environment: System: FreeBSD nuuk.fillmore-labs.com 5.1-CURRENT >Description: I used -not instead of ! in find to avoid the notorious problems with tcsh, not too smart. Credits go to Colin Percival <colin.percival@wadham.ox.ac.uk> >How-To-Repeat: >Fix: -------- Original Message -------- Subject: Re: ports/62499: PLIST_FILES-ify my ports Date: Sun, 08 Feb 2004 23:20:58 +0000 From: Colin Percival <colin.percival@wadham.ox.ac.uk> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> At 19:14 08/02/2004, Oliver Eikemeier wrote: >Release-Note: >Audit-Trail: >Unformatted: >add-plist-docs: > @${FIND} -P ${PORTDOCS:S/^/${DOCSDIR}\//} -not -type d > >and look what the output on your machine is? Aha! The -not option is broken in FreeBSD {4.7,5.0}, and doesn't exist at all for earlier versions. The following fixes PORTDOCS handling on systems more than a year old: --- bsd.port.mk.orig Sun Feb 8 23:16:49 2004 +++ bsd.port.mk Sun Feb 8 23:17:01 2004 @@ -4895,1 +4895,1 @@ - @${FIND} -P ${PORTDOCS:S/^/${DOCSDIR}\//} -not -type d 2>/dev/null | \ + @${FIND} -P ${PORTDOCS:S/^/${DOCSDIR}\//} ! -type d 2>/dev/null | \ Colin Percival
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4028B70A.8060402>