Date: Mon, 10 Aug 2015 23:00:43 -0700 From: Xin Li <delphij@delphij.net> To: Ed Schouten <ed@nuxi.nl>, d@delphij.net Cc: Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286601 - head/usr.bin/patch Message-ID: <55C98F8B.4020103@delphij.net> In-Reply-To: <CABh_MKkfXa6mEc%2B6wPpw5b2W=RwC%2BiNVNb7k85LPvLCS_kRgrA@mail.gmail.com> References: <201508102131.t7ALVo5J050735@repo.freebsd.org> <CABh_MKk5uOupQx9farP3_5D1J0f-5fAt0EXqnhautx0TNm9AaA@mail.gmail.com> <55C931CE.3030806@delphij.net> <CABh_MKkfXa6mEc%2B6wPpw5b2W=RwC%2BiNVNb7k85LPvLCS_kRgrA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 8/10/15 22:51, Ed Schouten wrote: > 2015-08-11 1:20 GMT+02:00 Xin Li <delphij@delphij.net>: >> Do you have a better solution for this? No, this is not ideal >> but I didn't find a better alternative (or maybe I have missed >> something obvious?) >> >> I think with the current POSIX definition of the interface, we >> have only two options: either strdup() or cast away const (I'd >> rather hide this kind of uglyness in the library), no? > > Casting const away should be all right in this case. Committed as r286617, please let me know if you want other changes, etc. Perhaps we should convert the tree over time to use __DECONST instead then? Cheers, -----BEGIN PGP SIGNATURE----- iQIbBAEBCgAGBQJVyY+KAAoJEJW2GBstM+nsI4MP+LG3zqlTe2UvL+AL03K2LECM 3qXdiDjkFEhlmyTJ4lQIO2BgqOfQSvxkxaeCs8mMYuOSyPFVmk9tYgS57QKkcoPq rqDCD+w8P0njzvC+PhD5FNBaY0PEq3uapyoqAMvbSMWKS6n4d1Mw5nHrWm3frkS4 filVI5ZBiP+FvxEYZIraqi/D9GFwsGDiaJoQFkn8KN/SjCq4nu01MMWXs9uwYFn7 dsf6xBiXw2XS5ugCQoJvE73EqtUQKNYXFLpqWFDfOroKPN+vILaZRgYeXERJazNh Sx8FWU97BioZhujn9XCS+68MLezS+5tN/ky6PAkcDpih3oW5z5q8E0wKHPR6UTKl 651d1NMfiP9bHYLErA2K8zl5iZ3LsIUikxeJE5nh33Mw02tgjlKkXbXq9AMen9Au Pcl7q09FYXf9RYmBbWrMfGaZdAlWpbP1DMKsVrKabXIXiKbieY+GF8knxJuuEdtS ZqxGlgXeMCWgRDix84ZYYqDSrJsEc0/0EyrlabLuTtf84Ax2xmtUGxt24O0y2S5u 8gJyji39ed0PneRAlPztFz0jiK++KmyLJOAI+cU3oNWoE+tIT+NwKWe7btZuR6A6 Oo0kGrTLX3VQkGOzRYiNd8NYOAGRzGppvuGsEEesAJF1NxX/Yu1rW9Cr7GQ9juWj 7/2k0+Nzy4p7i58Gkn4= =LyPN -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55C98F8B.4020103>