From owner-p4-projects@FreeBSD.ORG Sat Nov 22 17:58:08 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E94D21065672; Sat, 22 Nov 2008 17:58:07 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD273106568E for ; Sat, 22 Nov 2008 17:58:07 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A37668FC1A for ; Sat, 22 Nov 2008 17:58:07 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mAMHw7Gh070470 for ; Sat, 22 Nov 2008 17:58:07 GMT (envelope-from nwhitehorn@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mAMHw7cB070468 for perforce@freebsd.org; Sat, 22 Nov 2008 17:58:07 GMT (envelope-from nwhitehorn@freebsd.org) Date: Sat, 22 Nov 2008 17:58:07 GMT Message-Id: <200811221758.mAMHw7cB070468@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to nwhitehorn@freebsd.org using -f From: Nathan Whitehorn To: Perforce Change Reviews Cc: Subject: PERFORCE change 153362 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2008 17:58:08 -0000 http://perforce.freebsd.org/chv.cgi?CH=153362 Change 153362 by nwhitehorn@nwhitehorn_trantor on 2008/11/22 17:57:25 In retrospect, invoking KTR from pmap_cpu_boostrap() is a bad idea. There are no guarantees that something as complicated as a console will do anything useful coming right off CPU reset. Affected files ... .. //depot/projects/ppc-g5/sys/powerpc/powerpc/pmap_dispatch.c#4 edit Differences ... ==== //depot/projects/ppc-g5/sys/powerpc/powerpc/pmap_dispatch.c#4 (text+ko) ==== @@ -411,7 +411,10 @@ void pmap_cpu_bootstrap(int ap) { - CTR3(KTR_PMAP, "%s(%#x, %#x)", __func__, pa, size); + /* + * No KTR here because our console probably doesn't work yet + */ + return (MMU_CPU_BOOTSTRAP(mmu_obj, ap)); }