From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Mar 10 02:49:51 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C9AC216A4F1
	for <freebsd-ports-bugs@FreeBSD.org>;
	Wed, 10 Mar 2004 02:49:50 -0800 (PST)
Received: from postman.arcor.de (postman4.arcor-online.net [151.189.0.154])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3F40F43D45
	for <freebsd-ports-bugs@FreeBSD.org>;
	Wed, 10 Mar 2004 02:49:50 -0800 (PST)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from fillmore.dyndns.org (port-212-202-51-138.reverse.qsc.de
	[212.202.51.138])	(authenticated bits=0)i2AAnlD2017427
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Wed, 10 Mar 2004 11:49:48 +0100 (MET)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD)
	id 1B11HO-000JKl-1u; Wed, 10 Mar 2004 11:49:38 +0100
Message-ID: <404EF2C3.4060103@fillmore-labs.com>
Date: Wed, 10 Mar 2004 11:49:39 +0100
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
References: <200403100950.i2A9o88s074438@freefall.freebsd.org>
	<Pine.BSF.4.53.0403101009050.843@e0-0.zab2.int.zabbadoz.net>
In-Reply-To: <Pine.BSF.4.53.0403101009050.843@e0-0.zab2.int.zabbadoz.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/64027: [Maintainer] lang/pnet* -- add PORTDOCS andmissing
 lib for X support.
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Mar 2004 10:49:51 -0000

Bjoern A. Zeeb wrote:

> On Wed, 10 Mar 2004, Oliver Eikemeier wrote:
> 
> 
>>The following reply was made to PR ports/64027; it has been noted by GNATS.
>>
>>From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
>>To: michael johnson <ahze@ahze.net>
>>Cc: freebsd-gnats-submit@FreeBSD.org
>>Subject: Re: ports/64027: [Maintainer] lang/pnet* -- add PORTDOCS and missing
>> lib for X support.
>>Date: Wed, 10 Mar 2004 10:39:54 +0100
>>
>> michael johnson wrote:
>>
>> > +.ifndef(PORTDOCS)
>> > +.for plistfile in ${DOC_FILES}
>> > +PLIST_FILES+=	share/doc/${PORTNAME}/${plistfile}
>> > +.endfor
>> > +PLIST_DIRS+=	share/doc/${PORTNAME}
>> > +.endif
>> > +
>>
>> You could write
>>   PORTDOCS=	${DOC_FILES}
>> instead
> 
> if he installs documentations to DOCSDIR why not simply use
> (what Greg lately pointed me to) ?
> 
> .if !defined(NOPORTDOCS)
> PORTDOCS=	*
> .endif

You are right, this is fine if you are sure that you own *all* documents in 
DOCSDIR (which ports usually do). It may be inappropriate when ports share 
DOCSDIR, like exim and the exim-doc-* ports. I didn't read the ports 
thoroughly enough to be on the safe side, so I decided to simply use 
DOC_FILES. Feel free to use whatever suits you best.