Date: Thu, 21 Oct 2004 12:54:40 -0400 (EDT)
From: Christopher Nehren <apeiron@comcast.net>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: ports/72968: Broken network support in x{mame,mess} partially failing silently
Message-ID: <200410211654.i9LGseF2075376@prophecy.dyndns.org>
Resent-Message-ID: <200410211700.i9LH0Elj071206@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 72968
>Category: ports
>Synopsis: Broken network support in x{mame,mess} partially failing silently
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Oct 21 17:00:14 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Christopher Nehren
>Release: FreeBSD 5.3-BETA7 i386
>Organization:
>Environment:
System: FreeBSD prophecy.dyndns.org 5.3-BETA7 FreeBSD 5.3-BETA7 #0: Sun Oct 10 13:50:39 EDT 2004 root@prophecy.dyndns.org:/usr/src/sys/i386/compile/PROPHECY i386
>Description:
As stated http://www.mail-archive.com/xmame@toybox.twisted.org.uk/msg07256.html,
networking support is currently known to be broken in xmame and xmess. The port
will still attempt to build network support, however, which will fail because
the code is broken. Apparently the port maintainer wants the port to continue
building but without networking support, and without notifying the user. This
silent failure can cause much confusion (it did for me and others, at least).
Therefore, I recommend marking the port as BROKEN rather than partially failing
silently. This way a user isn't led to believe -- under false pretenses -- that
their networking should still be working.
Also take note that the port does not properly disable networking support even
if it's enabled.
>How-To-Repeat:
Attempt to build recent xmame/xmess with networking support, notice the broken
code.
>Fix:
--- /usr/ports/emulators/xmame/Makefile Thu Oct 21 12:49:05 2004
+++ xmame/Makefile Thu Oct 21 12:48:55 2004
@@ -223,11 +223,8 @@
#.endif
.if ${WITH_NETWORK:L} != "no"
-NETWORK=
-.else
-NETWORK=\#
+BROKEN= "Network support is broken in 0.85+"
.endif
-#.endif
.include <bsd.port.pre.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410211654.i9LGseF2075376>