Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Aug 2016 19:20:26 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r305078 - head/sys/dev/iscsi_initiator
Message-ID:  <201608301920.u7UJKQtL017116@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Tue Aug 30 19:20:26 2016
New Revision: 305078
URL: https://svnweb.freebsd.org/changeset/base/305078

Log:
  iscsi_initiator: make logout_req::reason unsigned char
  
  Previously this reported an error from Clang 3.9.0: implict conversion
  from 'int' to 'char' changes value from 128 to -128.
  
  Discussed with:	dim, trasz
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D7699

Modified:
  head/sys/dev/iscsi_initiator/iscsi.h

Modified: head/sys/dev/iscsi_initiator/iscsi.h
==============================================================================
--- head/sys/dev/iscsi_initiator/iscsi.h	Tue Aug 30 19:02:15 2016	(r305077)
+++ head/sys/dev/iscsi_initiator/iscsi.h	Tue Aug 30 19:20:26 2016	(r305078)
@@ -356,7 +356,7 @@ typedef struct text_req {
 
 typedef struct logout_req {
      char	cmd;	// 0x06
-     char	reason;	// 0 - close session
+     u_char	reason;	// 0 - close session
      			// 1 - close connection
      			// 2 - remove the connection for recovery
      char	_2[2];



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608301920.u7UJKQtL017116>