Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 May 2003 17:04:38 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Garrett Wollman <wollman@lcs.mit.edu>
Cc:        Nate Lawson <nate@root.org>
Subject:   Re: cvs commit: src/sys/pci if_sis.c
Message-ID:  <XFMail.20030506170438.jhb@FreeBSD.org>
In-Reply-To: <200305062100.h46L0a1Z065872@khavrinen.lcs.mit.edu>

next in thread | previous in thread | raw e-mail | index | archive | help

On 06-May-2003 Garrett Wollman wrote:
> <<On Tue, 6 May 2003 13:57:47 -0700 (PDT), Nate Lawson <nate@root.org> said:
> 
>> I would rather you deleted the first call to callout_handle_init() instead
>> (after the "Inform the world" comment).  Reasons include poor style for
>> the first one and uniformity with other sys/pci/if_* drivers which do the
>> init right before ether_ifattach().
> 
> I would rather that drivers were fixed to use the new (FreeBSD 4)
> callout API, so that we can eventually deprecate the old one.

Agreed.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030506170438.jhb>