Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jul 2003 17:13:50 -0700 (PDT)
From:      Robert Drehmel <robert@FreeBSD.org>
To:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   cvs commit: src/sys/pci ncr.c
Message-ID:  <200307270013.h6R0Dolw035799@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
robert      2003/07/26 17:13:50 PDT

  FreeBSD src repository

  Modified files:
    sys/pci              ncr.c 
  Log:
  Changed the type of the variable `qidx' from u_int8_t to int,
  mainly to quiet a warning emitted by GCC 3.3 about comparing
  a variable to a value which is larger than the former can hold.
  
  The value was checked to make sure the `np->squeue' array is
  not accessed behind its boundary.
  This worked due to possibly accidental truncation when
  (np->squeueput + 1) was larger than or equal to MAX_START (256)
  when it was assigned to `qidx'.
  
  `qidx' is used to hold the next position in the start queue
  for an insertion.  The new type was chosen because some other
  code in the function ncr_freeze_devq() also uses plain integers
  to hold those indices.
  
  Wrapped the line after the closing parenthesis of an `if'
  condition.
  
  Revision  Changes    Path
  1.176     +3 -2      src/sys/pci/ncr.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200307270013.h6R0Dolw035799>