From owner-cvs-all Sat Apr 7 4: 2: 2 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 3448C37B424; Sat, 7 Apr 2001 04:01:54 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f37B28U24998; Sat, 7 Apr 2001 12:02:08 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f37B1ul55453; Sat, 7 Apr 2001 12:01:56 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104071101.f37B1ul55453@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Dima Dorfman , mckusick@FreeBSD.org Cc: Bruce Evans , Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps ps.c In-Reply-To: Message from Dima Dorfman of "Sat, 07 Apr 2001 01:04:12 PDT." <20010407080412.E21673E09@bazooka.unixfreak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 07 Apr 2001 12:01:56 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Bruce Evans writes: > > On Fri, 6 Apr 2001, Brian Somers wrote: > > > Log: > > > The sess column went away last December with v1.26 of keyword.c > > > Remove it from ``jfmt''. > > > > > > Forgotten by: mckusick > > > > This stomps on PR 26057, which contains more complete fixes. It's > > not clear whether the bug is the non-removal of the sess column and > > the sess keyword or the removal of the e_sess pointer. > > This particular commit doesn't really hurt anything. We just need to > decide whether there should be an e_sess (or ki_sess, now) pointer or > not. PR 26057, which you mention, contains a patch to add it back. > Although mckusick did explicitly say he was removing it in his > kproc_info commit, he didn't provide rationale. > > So, the question is: do we want a `sess' column? Personally I preferred it *with* the sess column (my change just removed an irritating error message - I use ``ps j'' all the time and have eventually gotten sick of seeing it). Kirk, do you have any objections to restoring sess ? > Regards, > > Dima Dorfman > dima@unixfreak.org Cheers. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message