From owner-svn-src-head@freebsd.org Fri Sep 18 19:44:08 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0160A3EDBCA; Fri, 18 Sep 2020 19:44:08 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BtPRC6FzNz427b; Fri, 18 Sep 2020 19:44:07 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x744.google.com with SMTP id 16so7539282qkf.4; Fri, 18 Sep 2020 12:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FfBJ1UYcCPImIYu2EwcB4YKcdpvNwZU9bCmIicqtJ7M=; b=Nvmx+lB6VpUUCE2CCYx6r8gCwt11xv8HhzqXHLMMjhvFQ89k+cCwq4m9RaBxYsxrWg yNfYzHl0tHNu+DCVAfF4JJsGlE6tOTQNWz96ag7eacTLSLznCvGgRn2XHOZrFlmwpmOL WuF16xXMDmD8B6w8tneKuY7yAOgx7QzT+utJrl1b9f38yi+al9XwI6Dnzv6eWewfpBRR p36aXdisfhn0a37WlKpymU/IfT47zBcnToeuLZemwbnilqokQ7rFNvUQa+0lCsWGiqNF sqUF622TEsx22TAnLuTQ/taWkcmSDDqfLAt8M3HgsDAPheHaU8e4L7RzdMdKBPIE7xr+ 7NGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=FfBJ1UYcCPImIYu2EwcB4YKcdpvNwZU9bCmIicqtJ7M=; b=gvpUrfjo2Gfr0x23MHfRrEpfFOaESM7q6+dbZft5dm2fKdqgJ3cEwQ8eQnUxhIXYT7 dVSPIc+5RdthyhzLazIOKxIH9tuLA0tTLHg9Whk+KGItSQ9BGqi0D709RqmSbfMWlH6r gNFbuT3ghiq93gs6wkucxx0xHawuIaUwrkpFNXiqsvIbYJtex6kP7VaHlAJ608IiWPBM ei/4NFGCzeUakzn4Hz+oITx9C0iHe7naTah9004Fnwup8aYgRCXHwWoEXer+JsceaRzH D+qpshFc0bk+8fnx8s9hMjHS1QqcPpA/4lxyfAK/12lGNSxSaeNVZ1fDHnnnLxBRwcpv 93GQ== X-Gm-Message-State: AOAM531ZZan/M3p3NxjWXQkBxLpOeWJmiBLWN66eosUUk8e7wBnp69yq T19aIb1RZrcyo1JaJCEEX92sBZesOmRd0A== X-Google-Smtp-Source: ABdhPJy9ibBtDSg4mv/A1vcL3OvYnSE7e84DTsezQX3VXqV/ZHkc2a2LF3znbs6MBCWxQoGCeU2DhA== X-Received: by 2002:a37:9c86:: with SMTP id f128mr35247724qke.30.1600458246410; Fri, 18 Sep 2020 12:44:06 -0700 (PDT) Received: from raichu (bras-vprn-toroon0560w-lp130-18-184-148-120-111.dsl.bell.ca. [184.148.120.111]) by smtp.gmail.com with ESMTPSA id o28sm2912739qtl.62.2020.09.18.12.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 12:44:05 -0700 (PDT) Sender: Mark Johnston Date: Fri, 18 Sep 2020 15:44:00 -0400 From: Mark Johnston To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365889 - head/share/mk Message-ID: <20200918194400.GA36442@raichu> References: <202009181903.08IJ3YTM014958@repo.freebsd.org> <311b50c504a5dc1e54a1442aa4f759b14f263b67.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <311b50c504a5dc1e54a1442aa4f759b14f263b67.camel@freebsd.org> X-Rspamd-Queue-Id: 4BtPRC6FzNz427b X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 19:44:08 -0000 On Fri, Sep 18, 2020 at 01:27:23PM -0600, Ian Lepore wrote: > On Fri, 2020-09-18 at 19:03 +0000, Mark Johnston wrote: > > Author: markj > > Date: Fri Sep 18 19:03:34 2020 > > New Revision: 365889 > > URL: https://svnweb.freebsd.org/changeset/base/365889 > > > > Log: > > Install library symlinks atomically. > > > > As we do for shared library binaries, pass -S to install(1) when > > installing symlinks. Doing so helps avoid transient failures when > > libraries are being reinstalled, which seems to be the root cause > > of > > spurious libgcc_s.so link failures during CI builds. > > > > Actually, I believe this will just paper over the real problem, which > is the fact that we're building and installing the same library > multiple times during early build steps. Nobody has yet been able to > explain why we do that, and I haven't been able to figure out why by > analyzing any differences in the generated files, but I'm not done > trying. Sorry, this deserved more commentary in the commit log. Indeed, we install libgcc_s.so multiple times during buildworld. As far as I can see, it's intentional insofar as libgcc_s.so is listed in multiple library targets: it's in both _prereq_libs and _startup_libs in Makefile.inc1. In particular, from scanning the log from a recent instance of the failure, libgcc_s gets built once but installed multiple times. Why that's the case, or whether it's still necessary, is not clear to me. But adding -S seemed like a desirable change in general, so I went forward with it.