Date: Mon, 11 Mar 2013 10:54:53 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Jean-S??bastien P??dron <dumbbell@FreeBSD.org> Cc: svn-src-head@freebsd.org, Konstantin Belousov <kostikbel@gmail.com>, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org> Subject: Re: svn commit: r248060 - in head/sys/dev/drm2: . ttm Message-ID: <20130311085453.GQ3794@kib.kiev.ua> In-Reply-To: <513D985F.40902@FreeBSD.org> References: <201303081811.r28IB2JI009017@svn.freebsd.org> <CAF6rxgka6kg9raW-v4iQ5WY80d0eQg0Lg87pCFqeQTGUdJ7W=g@mail.gmail.com> <513D985F.40902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wR9Y6Ks0OCEmDFVd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Mar 11, 2013 at 09:39:59AM +0100, Jean-S??bastien P??dron wrote:
> Hi Eitan!
>=20
> On 08.03.2013 19:14, Eitan Adler wrote:
> > On 8 March 2013 13:11, Jean-Sebastien Pedron <dumbbell@freebsd.org> wro=
te:
> >> @@ -125,8 +125,6 @@ static ssize_t ttm_mem_zone_store(struct
> >>
> >> static void ttm_mem_global_kobj_release(struct ttm_mem_global *glob)
> >> {
> >> -
> >> - free(glob, M_TTM_ZONE);
> >> }
> >=20
> > Can this function now be removed, because it appears to be empty?
>=20
> I guess we could get rid of the reference counting too, because we
> already have a refcount in the struct drm_global_reference containing
> struct ttm_mem_global or struct ttm_bo_global. This needs further
> investigation though.
>=20
> Konstantin, what do you think about this?
I do not like neither removing the release method, nor reference counting.
I made only absolutely neccessary changes to the TTM to get it into
FreeBSD. What is proposed is a start of rewrite.
--wR9Y6Ks0OCEmDFVd
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iQIcBAEBAgAGBQJRPZvdAAoJEJDCuSvBvK1B7eYQAJ+JwopU75ukPp3X201Bmtnt
bpZq340oO+NNheQ1nEVI0ObwPr/xPnME7H7cqj6p/JW+/ttk+SLKl7ZtgWVLw+QZ
hjQzxwaXkJvgx/fwkFsfoKMy2KrxAssg2N9GdRAw30uO+nIVNHbOsiISPjKTUxWf
cnoBEwxGdyILRsEAC1+WOqHDI5IaiN0d4eUl4VT2Jc8G69htP+Mjc1Slhle3MkKA
0j5KbpXPJsA76bI+Ltum+c/JdW5hSWq/ugiuIIs8/NYO4dDaY5kxmzpqmN4Yrz3h
io1btt678UYKNpG1v6eyGZrEVu3+2vsSacpJAvEil67K6lXQ0ZeJGny7Aj/m+5SU
qEAlnyslA3alrzqHoyKK3yK9rKtF26xJ1LyWd+nJ/x13pT4Pg7DntXf7rlgWWP+B
8DLkd8EFeFPVC2fM9r8wajbpFAim2LZviRA4Yvi1LgFTM/qDCfABAwztnz7F9Jm6
QMqkbQSH/RnZMjQw610Vv+0Au90q+uzjszRTdIDiH9VEJlXRKpkdQ5KI6ZOnQKE4
pYo855OXdVfnaly1yLNAoUl8T0CW4ElmT5gXcan8PjUSgr0SQsDF+/dktPUngMdt
2GI3B01FtZR6l1eb0LgFSU5iTcJXdUmNKbPaJirfhHrYn/n+RPEUToZkWKWTgl/G
L1iIuNUJUv3ph81+GTeo
=GuA1
-----END PGP SIGNATURE-----
--wR9Y6Ks0OCEmDFVd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130311085453.GQ3794>