Date: Mon, 5 Apr 2010 00:27:42 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Peter Jeremy <peterjeremy@acm.org> Subject: Re: svn commit: r206129 - head/sys/kern Message-ID: <20100404212742.GJ2415@deviant.kiev.zoral.com.ua> In-Reply-To: <4BB9006A.8080301@freebsd.org> References: <201004030839.o338d0VV032828@svn.freebsd.org> <20100404210314.GH86236@server.vk2pj.dyndns.org> <4BB9006A.8080301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--SWXyBy1zHAaCX+aB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 05, 2010 at 12:11:06AM +0300, Andriy Gapon wrote: > on 05/04/2010 00:03 Peter Jeremy said the following: > > On 2010-Apr-03 08:39:00 +0000, Andriy Gapon <avg@FreeBSD.org> wrote: > >> Author: avg > >> Date: Sat Apr 3 08:39:00 2010 > >> New Revision: 206129 > >> URL: http://svn.freebsd.org/changeset/base/206129 > >> > >> Log: > >> vn_stat: take into account va_blocksize when setting st_blksize > >> =20 > >> As currently st_blksize is always PAGE_SIZE, it is playing safe to not > >> use any smaller value. For some cases this might not be optimal, but > >> at least nothing should get broken. > >=20 > > I haven't verified it but, based on a quick look at the change, I > > suspect this will trigger the problem in bin/144446. Quick summary: > > db(3) has restrictions on its internal bucket size but initializes it > > from st_blksize with no sanity checking and ZFS can report blocksizes > > outside the allowed bucket size range for db(3). > >=20 >=20 > Thank you for pointing this out. > If no one objects or provides a better patch, I will commit yours. I do not think this is very satisfying solution. Pre-patched libc still suffer from the problem. You cannot run stable/8 libc on this kernel. --SWXyBy1zHAaCX+aB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAku5BE0ACgkQC3+MBN1Mb4i8PACeLAJrwJXYW1GK9k/0c6aWDoE9 VW4An3RkW13AXI7KoamKOB96AnT0uIXi =Dk4l -----END PGP SIGNATURE----- --SWXyBy1zHAaCX+aB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100404212742.GJ2415>