From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Apr  5 23:30:01 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id D356EA33
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri,  5 Apr 2013 23:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id A1EF5244
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri,  5 Apr 2013 23:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r35NU1x3010220
 for <freebsd-ports-bugs@freefall.freebsd.org>; Fri, 5 Apr 2013 23:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r35NU1Vo010219;
 Fri, 5 Apr 2013 23:30:01 GMT (envelope-from gnats)
Resent-Date: Fri, 5 Apr 2013 23:30:01 GMT
Resent-Message-Id: <201304052330.r35NU1Vo010219@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 john marino <draco@marino.st>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 205296A7
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  5 Apr 2013 22:34:00 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 11E8212E
 for <freebsd-gnats-submit@FreeBSD.org>; Fri,  5 Apr 2013 22:34:00 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r35MXxwR019774
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 5 Apr 2013 22:33:59 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r35MXxx7019773;
 Fri, 5 Apr 2013 22:33:59 GMT (envelope-from nobody)
Message-Id: <201304052233.r35MXxx7019773@red.freebsd.org>
Date: Fri, 5 Apr 2013 22:33:59 GMT
From: john marino <draco@marino.st>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/177660: news/noffle: [PATCH] Fix three unterminated strings in
 makefile
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2013 23:30:01 -0000


>Number:         177660
>Category:       ports
>Synopsis:       news/noffle: [PATCH] Fix three unterminated strings in makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 05 23:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     john marino
>Release:        
>Organization:
>Environment:
>Description:
The news/noffle Makefile has three unterminated strings fed to echo commands.  bmake doesn't like it, it breaks installation.  Patch attached.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2013-04-05 22:02:52.210286000 +0000
+++ Makefile
@@ -46,12 +46,12 @@ do-install:
 		${PREFIX}/man/man5
 	${INSTALL_DATA} ${WRKSRC}/noffle.conf.example \
 		${PREFIX}/etc/noffle.conf.sample
-	@${ECHO} "
+	@${ECHO}
 	@${ECHO} "------------------------------------------------------------"
 	@${ECHO} "Sample of configuration file placed at"
 	@${ECHO} "${PREFIX}/etc/noffle.conf.sample"
-	@${ECHO} "------------------------------------------------------------
-	@${ECHO} "
+	@${ECHO} "------------------------------------------------------------"
+	@${ECHO}
 	@${MKDIR} ${SPOOL_DIR}
 	@${MKDIR} ${SPOOL_DIR}/data
 	@${MKDIR} ${SPOOL_DIR}/lock


>Release-Note:
>Audit-Trail:
>Unformatted: