From owner-freebsd-standards Thu Mar 21 12:42: 2 2002 Delivered-To: freebsd-standards@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id A87F737B400 for ; Thu, 21 Mar 2002 12:41:59 -0800 (PST) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g2LKfwi83352 for ; Thu, 21 Mar 2002 13:41:58 -0700 (MST) (envelope-from imp@village.org) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g2LKftL19437 for ; Thu, 21 Mar 2002 13:41:55 -0700 (MST) (envelope-from imp@village.org) Date: Thu, 21 Mar 2002 13:41:51 -0700 (MST) Message-Id: <20020321.134151.58406849.imp@village.org> To: standards@freebsd.org Subject: Comments on this patch from pendants From: "M. Warner Losh" X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-standards@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Looks like this is the only place in our whole tree that we use or depend on _REENTRANT being defined. I don't see why we need it. Can the standards czars on this list comment about the pros and cons of this patch? Thanks much Warner Index: src/math.h =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/lib/msun/src/math.h,v retrieving revision 1.11 diff -u -r1.11 math.h --- src/math.h 13 Dec 2001 17:22:17 -0000 1.11 +++ src/math.h 21 Mar 2002 20:37:07 -0000 @@ -182,10 +182,8 @@ * Reentrant version of gamma & lgamma; passes signgam back by reference * as the second argument; user must allocate space for signgam. */ -#ifdef _REENTRANT double gamma_r __P((double, int *)); double lgamma_r __P((double, int *)); -#endif /* _REENTRANT */ /* float versions of ANSI/POSIX functions */ float acosf __P((float)); @@ -264,10 +262,8 @@ * signgam back by reference as the second argument; user must * allocate space for signgam. */ -#ifdef _REENTRANT float gammaf_r __P((float, int *)); float lgammaf_r __P((float, int *)); -#endif /* _REENTRANT */ #endif /* !_XOPEN_SOURCE */ #endif /* !_ANSI_SOURCE && !_POSIX_SOURCE */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message