Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 May 2018 08:27:33 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r334026 - head/sys/kern
Message-ID:  <201805220827.w4M8RXeQ051989@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Tue May 22 08:27:33 2018
New Revision: 334026
URL: https://svnweb.freebsd.org/changeset/base/334026

Log:
  Reduce sdt-related branch-fest in mi_switch.
  
  The code was evaluating flags before resorting to checking if dtrace is
  enabled. This was inducing forward jumps in the common case.

Modified:
  head/sys/kern/kern_synch.c

Modified: head/sys/kern/kern_synch.c
==============================================================================
--- head/sys/kern/kern_synch.c	Tue May 22 07:56:58 2018	(r334025)
+++ head/sys/kern/kern_synch.c	Tue May 22 08:27:33 2018	(r334026)
@@ -431,8 +431,9 @@ mi_switch(int flags, struct thread *newtd)
 	CTR4(KTR_PROC, "mi_switch: old thread %ld (td_sched %p, pid %ld, %s)",
 	    td->td_tid, td_get_sched(td), td->td_proc->p_pid, td->td_name);
 #ifdef KDTRACE_HOOKS
-	if ((flags & SW_PREEMPT) != 0 || ((flags & SW_INVOL) != 0 &&
-	    (flags & SW_TYPE_MASK) == SWT_NEEDRESCHED))
+	if (__predict_false(sdt_probes_enabled) &&
+	    ((flags & SW_PREEMPT) != 0 || ((flags & SW_INVOL) != 0 &&
+	    (flags & SW_TYPE_MASK) == SWT_NEEDRESCHED)))
 		SDT_PROBE0(sched, , , preempt);
 #endif
 	sched_switch(td, newtd, flags);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805220827.w4M8RXeQ051989>