Date: Wed, 8 Oct 2003 20:23:00 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Marcel Moolenaar <marcel@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/savecore savecore.c Message-ID: <20031008201225.U4605@gamplex.bde.org> In-Reply-To: <200310080737.h987bBYS028838@repoman.freebsd.org> References: <200310080737.h987bBYS028838@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 8 Oct 2003, Marcel Moolenaar wrote: > marcel 2003/10/08 00:37:11 PDT > > FreeBSD src repository > > Modified files: > sbin/savecore savecore.c > Log: > Revision 1.61 changed the allocation of buffer 'buf' in DoFile() from > the stack to the heap to work around a problem on ia64. Now, roughly > 16 months and two compiler updates later, it isn't an issue anymore > in the sense that putting a 1M buffer on the stack just works and we > don't actually need to work around anything anymore. > However, since there's no advantage or need to put the buffer on the > stack (again), this change merely removes the XXX comment describing > that there's an explicit reason for the heap allocation. Hence, this > change is a functional no-op. > > PR: ia64/38677 There is a negative advantage to putting the buffer on the stack. It asks for a misaligned buffer. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031008201225.U4605>