Date: Sun, 3 Dec 2000 15:05:08 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Matthew Jacob <mjacob@feral.com> Cc: Alfred Perlstein <bright@wintelcom.net>, Doug Rabson <dfr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c interrupt.c mp_machdep.c prom.c vm_machdep.c Message-ID: <Pine.BSF.4.21.0012031444001.720-100000@besplex.bde.org> In-Reply-To: <Pine.LNX.4.21.0011191245380.20827-100000@zeppo.feral.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 19 Nov 2000, Matthew Jacob wrote: > On Sun, 19 Nov 2000, Alfred Perlstein wrote: > > > * Doug Rabson <dfr@FreeBSD.org> [001119 04:29] wrote: > > > dfr 2000/11/19 04:28:42 PST > > > > > > Modified files: > > > sys/alpha/alpha clock.c db_interface.c interrupt.c > > > mp_machdep.c prom.c vm_machdep.c > > > Log: > > > Convert various calls to splhigh() to disable_intr() since splhigh() is > > > now a no-op. > > > > Afaik the concensus was that spl's were not to be removed even > > though they are no-ops. > > > > You should probably put them back. > > No, actually they're needed and they are there. Um, "they" (the spls) were replaced by disable_intr()/enable_intr(), so they are not there. > This is all specifically > machine dependent code areas, and places where, for example, the prom is > entered, interrupts really do need to be disabled. Disabling interrupts for one CPU is probably insufficient for the SMP case. The old code was broken if it actually required interrupts to be disabled. splhigh() might not disable interrupts. In fact, it can't disable interrupts if fast interrupts actually work. Similarly for new locking functions. Don't assume that mtx_enter() disables interrupts, although this is a documented (mis)feature for the MTX_SPIN case, since this is an implementation detail (bug). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0012031444001.720-100000>