Date: Thu, 17 Dec 2020 15:58:31 -0500 From: Ed Maste <emaste@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-git <freebsd-git@freebsd.org> Subject: Re: Git commit message templates Message-ID: <CAPyFy2CGKgvjmAsFtVwBsuPaR6p6QF5X659fU9VFB%2Bf_N7vosg@mail.gmail.com> In-Reply-To: <c18f71b2-8356-c1ad-b0d7-9b742f2d9fb9@FreeBSD.org> References: <CAPyFy2DveYMw6VyxT8QwOCNreHTyi6RoYX1EWEfysMEqCpcjZQ@mail.gmail.com> <c18f71b2-8356-c1ad-b0d7-9b742f2d9fb9@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 16 Dec 2020 at 17:35, John Baldwin <jhb@freebsd.org> wrote: > > The only one I'm not a fan of is the lack of punctuation for the first > sentence. Newspaper headlines also use additional capitalization > (e.g. last word and "significant words"), so the current recommendation > is a mix of things and not fully consistent with either one. Fair point - considering the first line as one would an email subject is probably the best approach. If I look over the last year I see (using egrep -c on git log --since=1year --oneline): 8383 commits 3715 end in . 4668 do not end in . Of the 6372 commits less than 80 characters (including the short hash): 2416 end in . 4316 do not end in . > I suspect in > practice though that trailing punctuation might just vary by committer. > (That seems to be what happens in some other projects I've looked > at.) Yes, I expect this will happen in our repository as well.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CGKgvjmAsFtVwBsuPaR6p6QF5X659fU9VFB%2Bf_N7vosg>