From owner-freebsd-git@freebsd.org Thu Dec 17 20:58:46 2020 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF33A4C43A7 for ; Thu, 17 Dec 2020 20:58:46 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cxkqp4q3Rz4myf; Thu, 17 Dec 2020 20:58:46 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f49.google.com with SMTP id z136so28918419iof.3; Thu, 17 Dec 2020 12:58:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nt6mdLXR3608CS5pCQzC51C4VC+rG/q2zjyABzBHJsc=; b=uAh2rfhTPx2qJSZXD3mbxWt8I7R6CqWpSo0wVH8WMIbpic2v50i6caOLvZPgcKCHPt ti6UnyttZ2oieNNsluHo7AhROsY3KOXtsl+WOQyr5kfX+9sc4W7FOw1mR1YjWZPtvgL3 1jqObADJ6bN85yt0QBrHXEswduqi+H/Gn5pOOvkWf/2AkFE6yetRt1GkTpKX8spJkqGF t9efcITsBCRm8iHvcfuoQ0Zsw5mT4IYwNWD9Fp5ygW5vaGAtgzxe+HStZiQ8nzRd+iv9 Bv/n/hotsavwMaHiddvOxLfPrqjccJymhqanfCEksAowf1jsiWSv8PioClYER/eP2DC4 JSSQ== X-Gm-Message-State: AOAM533ICyM36hB9FAz4GdWec3AMT0wOsnHw34pzXlKmM+gNjxZGOJ0G cwAYWwhS4gwEry8UzdsprJDdbTjbQRfuXyBSwwrb+jRzqN4= X-Google-Smtp-Source: ABdhPJzOOyKrq3yJQU+cvkdPYKr+UST2dGak/2y2boooQ+Q2aNE6vELLYvUxXaGnZRPTFR2ldsU0Mwd3W9X9cweX7os= X-Received: by 2002:a6b:1451:: with SMTP id 78mr1046063iou.102.1608238724393; Thu, 17 Dec 2020 12:58:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Thu, 17 Dec 2020 15:58:31 -0500 Message-ID: Subject: Re: Git commit message templates To: John Baldwin Cc: freebsd-git Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Cxkqp4q3Rz4myf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 20:58:46 -0000 On Wed, 16 Dec 2020 at 17:35, John Baldwin wrote: > > The only one I'm not a fan of is the lack of punctuation for the first > sentence. Newspaper headlines also use additional capitalization > (e.g. last word and "significant words"), so the current recommendation > is a mix of things and not fully consistent with either one. Fair point - considering the first line as one would an email subject is probably the best approach. If I look over the last year I see (using egrep -c on git log --since=1year --oneline): 8383 commits 3715 end in . 4668 do not end in . Of the 6372 commits less than 80 characters (including the short hash): 2416 end in . 4316 do not end in . > I suspect in > practice though that trailing punctuation might just vary by committer. > (That seems to be what happens in some other projects I've looked > at.) Yes, I expect this will happen in our repository as well.