Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 31 Aug 2016 16:40:10 -0300
From:      Luiz Otavio O Souza <loos.br@gmail.com>
To:        Oleksandr Tymoshenko <gonzo@bluezbox.com>
Cc:        Luiz Otavio O Souza <loos@freebsd.org>, src-committers <src-committers@freebsd.org>,  svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r305114 - head/sys/arm/ti
Message-ID:  <CAJ8CS7r06itUfF9=FAAyZ8gdEWgimmYvpQbzYUQBjGcRSGQbjQ@mail.gmail.com>
In-Reply-To: <F9864B2F-E991-431B-9180-68A6F152F2B5@bluezbox.com>
References:  <201608310722.u7V7MEvA094475@repo.freebsd.org> <F9864B2F-E991-431B-9180-68A6F152F2B5@bluezbox.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 31, 2016 at 3:54 PM, wrote:
>
>> On Aug 31, 2016, at 12:22 AM, Luiz Otavio O Souza wrote:
>>
>> Author: loos
>> Date: Wed Aug 31 07:22:14 2016
>> New Revision: 305114
>> URL: https://svnweb.freebsd.org/changeset/base/305114
>>
>> Log:
>>  Allow the use of control module extensions to cope with specific platform
>>  features.
>>
>>  Sponsored by:        Rubicon Communications, LLC (Netgate)
>>
>> Modified:
>>  head/sys/arm/ti/ti_scm.c
>>
>> Modified: head/sys/arm/ti/ti_scm.c
>> ==============================================================================
>> --- head/sys/arm/ti/ti_scm.c  Wed Aug 31 07:03:06 2016        (r305113)
>> +++ head/sys/arm/ti/ti_scm.c  Wed Aug 31 07:22:14 2016        (r305114)
>> @@ -131,7 +131,11 @@ ti_scm_attach(device_t dev)
>>
>>       ti_scm_sc = sc;
>>
>> -     return (0);
>> +     /* Attach platform extensions, if any. */
>> +     bus_generic_probe(dev);
>> +     bus_enumerate_hinted_children(dev);
>> +
>> +     return (bus_generic_attach(dev));
>> }
>
> Is bus_enumerate_hinted_children really required? I think all TI platforms are FDT-compatible


No, it is not required.  Fixed in r305149.

Thanks!

Luiz



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ8CS7r06itUfF9=FAAyZ8gdEWgimmYvpQbzYUQBjGcRSGQbjQ>