Date: Fri, 6 Apr 2012 08:49:06 -0800 (AKDT) From: Mel Flynn <rflynn@acsalaska.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Steve Wills <swills@FreeBSD.org>, Mantainer <perl@FreeBSD.org> Subject: ports/166695: [patch] net/p5-Net-Radius: Fix test breakage Message-ID: <201204061649.q36Gn6Li085092@datakitty.lan.rachie.is-a-geek.net> Resent-Message-ID: <201204061650.q36GoAT8040146@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166695 >Category: ports >Synopsis: [patch] net/p5-Net-Radius: Fix test breakage >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 06 16:50:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mel Flynn >Release: FreeBSD 8.2-STABLE amd64 >Organization: >Environment: System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64 >Description: The post-extract target deletes carriage returns from all files in the distribution. There's only one file containing a carriage return and this isn't the usual case of "windows line endings", but is part of a binary packet. Removing these carriage returns breaks t/packet.t for that packet test. >How-To-Repeat: cd /usr/ports/net/p5-Net-Radius make build cd `make -V WRKSRC` make test >Fix: While in here, add TEST_DEPENDS. --- net__p5-Net-Radius.patch begins here --- Removing \r in packets/huawei-me60-accreq-01.p will make the tests fail. diff -urN --exclude CVS --exclude '*~' net/p5-Net-Radius/Makefile /usr/ports/net/p5-Net-Radius/Makefile --- net/p5-Net-Radius/Makefile.orig 2009-12-14 21:26:23.000000000 -0900 +++ net/p5-Net-Radius/Makefile 2012-04-06 07:56:26.000000000 -0800 @@ -14,10 +14,10 @@ MAINTAINER= perl@FreeBSD.org COMMENT= A perl module to manipulate RADIUS packets +TEST_DEPENDS= p5-Test-Warn>=0:${PORTSDIR}/devel/p5-Test-Warn \ + p5-Test-Pod>=0:${PORTSDIR}/devel/p5-Test-Pod + PERL_CONFIGURE= yes MAN3= Net::Radius::Dictionary.3 Net::Radius::Packet.3 -post-extract: - ${FIND} ${WRKDIR} -type f | ${XARGS} ${PERL5} -pi -e "s:\r::g" - .include <bsd.port.mk> --- net__p5-Net-Radius.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204061649.q36Gn6Li085092>