From owner-svn-ports-head@FreeBSD.ORG Tue Mar 11 13:42:22 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63B38742; Tue, 11 Mar 2014 13:42:22 +0000 (UTC) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [IPv6:2a00:1450:400c:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7BB1F83E; Tue, 11 Mar 2014 13:42:21 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id p61so10208059wes.27 for ; Tue, 11 Mar 2014 06:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ILu3Urgr4wWgy6UTSD9hbwSb6kbkzhz+MTjrDx96uBA=; b=tuE4+6qOIxDT+QgQzUrrEOYMMM5bn7SHwYckM7nU2PUk+9+ltPZPhsYY6gNjP2NZf3 1lkQQA03zH64pGg5AWe9ShBLkUTTSmCdGVhUJECYA9WGmJUAC2bJ38VPjcEw8324pmeM 6NfdUKL5UcWOW2+ipJSeRs7U2gNXpkm3Xy5JqNiXLRzdZUDvn5uiNXBVpVrznhdZ6IQM Y19PLQ3aqsWV+9VsTuBZja/tVyx5sPJbWWVBnABjM8NHALGtHzHPp5YofrsjXFhrcG05 2ADWb5wTGkxfOBL5TSNtsf78FZnfu+H8sF3xRV/G+TtN40BiFOKgQMOJqUAtD1kM4ej2 qgGg== X-Received: by 10.180.219.44 with SMTP id pl12mr3172345wic.12.1394545339732; Tue, 11 Mar 2014 06:42:19 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id n15sm6709092wij.3.2014.03.11.06.42.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Mar 2014 06:42:18 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 11 Mar 2014 14:42:16 +0100 From: Baptiste Daroussin To: Alex Kozlov Subject: Re: svn commit: r347857 - head/mail/thunderbird-dictionaries Message-ID: <20140311134216.GL6900@ithaqua.etoilebsd.net> References: <201403110640.s2B6eMDI022100@svn.freebsd.org> <20140311090000.GB78846@FreeBSD.org> <7E2CA333BD6C7A70FD270041@atuin.in.mat.cc> <20140311133443.GA26313@ravenloft.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E6lVPAHcXg6biC3t" Content-Disposition: inline In-Reply-To: <20140311133443.GA26313@ravenloft.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Mar 2014 13:42:22 -0000 --E6lVPAHcXg6biC3t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 11, 2014 at 03:34:43PM +0200, Alex Kozlov wrote: > On Tue, Mar 11, 2014 at 10:10:43AM +0100, Mathieu Arnold wrote: > > +--On 11 mars 2014 09:00:00 +0000 Alexey Dokuchaev > > wrote: > > | The way it's done now generates lots of needless mail traffic and repo > > | churn. It would also be nice if you could provide some details in the > > | commit logs WRT what's exactly is/was broken. Thank you, > >=20 > > Well, what was broken is simple, libarchive can't process the zip file = =66rom > > the distfiles, and the port needs to use the unzip command. > I think that in some (many?) cases problem is not in libarchive, but is in > the difference between tar and unzip. E.g for this port: >=20 > Index: mail/thunderbird-dictionaries/Makefile > @@ -15,7 +15,7 @@ > =20 > RUN_DEPENDS=3D thunderbird>=3D6.0:${PORTSDIR}/mail/thunderbird > =20 > -USES=3D zip:infozip > +USES=3D zip > NO_BUILD=3D yes > WRKSRC=3D ${WRKDIR}/dictionaries > =20 > @@ -58,7 +58,8 @@ > @${MKDIR} ${WRKSRC} > .for f in ${ALLDICTS} > .if ${PORT_OPTIONS:M${f}} > - @${UNZIP_CMD} -q ${DISTDIR}/${DIST_SUBDIR}/${${f}_FILE} -d ${WRKSRC}/${= ${f}_FILE} > + @${MKDIR} ${WRKSRC}/${${f}_FILE} > + @${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DIST_SUBDIR}/${${f}= _FILE} -C ${WRKSRC}/${${f}_FILE} > .endif > .endfor > =20 The thing is now everyone can dig for zip:infozip easily and fix them as ne= eded regards, Bapt --E6lVPAHcXg6biC3t Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlMfErcACgkQ8kTtMUmk6Ey7YACgqHBVmeN0YBGBekOPDpCnKuoL klAAoLgWqJAVZg8/S0zddPO+iU1/5wtw =YoDR -----END PGP SIGNATURE----- --E6lVPAHcXg6biC3t--