Date: Thu, 9 Mar 2006 22:38:18 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c Message-ID: <20060309203818.GD48078@ip.net.ua> In-Reply-To: <20060309185721.GE7835@green.homeunix.org> References: <200602221021.k1MAL5qF031937@repoman.freebsd.org> <20060307003911.GB7835@green.homeunix.org> <20060307133200.GA60850@garage.freebsd.pl> <20060309185721.GE7835@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+B+y8wtTXqdUj1xM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 09, 2006 at 01:57:21PM -0500, Brian Fundakowski Feldman wrote: > On Tue, Mar 07, 2006 at 02:32:00PM +0100, Pawel Jakub Dawidek wrote: > > On Mon, Mar 06, 2006 at 07:39:11PM -0500, Brian Fundakowski Feldman wro= te: > > +> On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote: > > +> > pjd 2006-02-22 10:21:05 UTC > > +> >=20 > > +> > FreeBSD src repository > > +> >=20 > > +> > Modified files: > > +> > sys/geom/raid3 g_raid3.c=20 > > +> > Log: > > +> > Do not use bio structure after g_io_deliver(), it may not longer= by valid. > > +> > =20 > > +> > Found and fixed by: Vsevolod Lobko <seva@ip.net.ua> > > +> > MFC after: 3 days > > +>=20 > > +> I actually found and fixed it half a year ago... could you please > > +> integrate the rest of the fixes from my changes back then? A > > +> short-term low-memory deadlock is still possible (observed in > > +> practice). I think the changes also improve readability -- see > > +> for example the reason r1.46 existed. > >=20 > > Heh. I own you apology. I haven't had time to work on graid3 back then > > and I also overlooked fix of this very problem. > >=20 > > I integrated you fixes to my last patch which I'm planning to commit > > after receiving some feedback: > >=20 > > http://people.freebsd.org/~pjd/patches/graid3.patch >=20 > Everything seems good to go, running -CURRENT's graid3 + these changes > on 6-STABLE; are there particular areas where you think I should try > testing for improved performance? >=20 I was fighting a problem today when our geom_cache attempts to fill 256K of bio_data coming from graid3, and this obviously fails because graid3 only allocates memory for first 64k from its 64k UMA zone. This patch doesn't fix this problem. I have MAXPHYS bumped to 512K, which is important to reproduce the problem. Can you please fix this? Temporarily, I've added 128/256/512 zones to satisfy my needs. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --+B+y8wtTXqdUj1xM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEEJI6qRfpzJluFF4RAhN4AJ9tqex20J2klT0cTRtlLzsiFEjwagCfblAc zhM3SQc8onC3SfevCrbEvyg= =q5QP -----END PGP SIGNATURE----- --+B+y8wtTXqdUj1xM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060309203818.GD48078>