From owner-svn-src-head@freebsd.org Tue Mar 14 21:03:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCCA5D0DAC2; Tue, 14 Mar 2017 21:03:54 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id A79AB1F53; Tue, 14 Mar 2017 21:03:54 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from sweettea.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 25F4856575; Tue, 14 Mar 2017 16:03:48 -0500 (CDT) Subject: Re: svn commit: r315277 - in head/sys: dev/cxgb/ulp/iw_cxgb netinet To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201703141827.v2EIRmLv080307@repo.freebsd.org> <1489518141.40576.119.camel@freebsd.org> From: Eric van Gyzen Message-ID: Date: Tue, 14 Mar 2017 16:03:47 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1489518141.40576.119.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 21:03:54 -0000 On 03/14/2017 14:02, Ian Lepore wrote: > On Tue, 2017-03-14 at 18:27 +0000, Eric van Gyzen wrote: >> Author: vangyzen >> Date: Tue Mar 14 18:27:48 2017 >> New Revision: 315277 >> URL: https://svnweb.freebsd.org/changeset/base/315277 >> >> Log: >> KTR: log IPv4 addresses in hex rather than dotted-quad >> > > Don't all those s_addr fields now need some ntohl() love to print > properly as an integer value? *sigh* Yes, of course. Fixed in r315286. Thanks, Ian. How did I get it right in several places in ip_mroute.c, but wrong in all the other places? That was rhetorical. Please, for my sake, don't share your postulations about my malfunctioning brain. Eric