Date: Sun, 6 Sep 1998 01:53:35 -0700 (PDT) From: Matthew Dillon <dillon@backplane.com> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: Doug Rabson <dfr@nlsystems.com>, John Birrell <jb@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen sleep.c Message-ID: <199809060853.BAA23932@apollo.backplane.com> References: <199809051816.LAA22705@apollo.backplane.com> <Pine.BSF.4.01.9809052157410.796-100000@herring.nlsystems.com> <19980906080311.A12205@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
ok, I'll commit it.
-Matt
:On Sat, Sep 05, 1998 at 09:58:19PM +0100, Doug Rabson wrote:
:> On Sat, 5 Sep 1998, Matthew Dillon wrote:
:>
:> > The sleep code is totally broken in regards to its comparisons. The
:> > argument is an unsigned int, but values are stored in time_t which is
:> > currently a signed long. The code, as it stands, is not clean if either
:> > time_t changes from signed to unsigned, or if time_t changes from a 32 bit
:> > value to a 64 bit value. Since there is no harm in doing multiple
:> > sleeps, why not just fix the code? We no tv_sec must be at least large
:> > enough to hold INT_MAX, so:
:>
:> Looks fine to me. If Andrey agrees, why don't you commit this.
:
:Ok for me too.
:
:--
:Andrey A. Chernov
:http://www.nagual.pp.ru/~ache/
:MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y
Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet
Communications & God knows what else.
<dillon@backplane.com> (Please include original email in any response)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809060853.BAA23932>