From owner-freebsd-fs@FreeBSD.ORG  Fri Jun 16 16:51:36 2006
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
X-Original-To: freebsd-fs@freebsd.org
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 24F5A16A508;
	Fri, 16 Jun 2006 16:51:36 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from Daffy.timing.com (w.timing.com [206.168.13.218])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A5E6943D46;
	Fri, 16 Jun 2006 16:51:35 +0000 (GMT)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id k5GGpYRD028652;
	Fri, 16 Jun 2006 10:51:34 -0600 (MDT)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.13.6/8.13.4) with ESMTP id k5GGpWgX076669;
	Fri, 16 Jun 2006 10:51:32 -0600 (MDT)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.13.6/8.13.6/Submit) id k5GGpW3g076666;
	Fri, 16 Jun 2006 10:51:32 -0600 (MDT) (envelope-from jhein)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17554.57748.372948.664580@gromit.timing.com>
Date: Fri, 16 Jun 2006 10:51:32 -0600
From: John Hein <jhein@timing.com>
To: Daichi GOTO <daichi@freebsd.org>
In-Reply-To: <44926377.5000005@freebsd.org>
References: <44926377.5000005@freebsd.org>
X-Mailer: VM 7.19 under Emacs 21.3.1
X-Virus-Scanned: ClamAV version 0.87.1,
	clamav-milter version 0.87 on Daffy.timing.com
X-Virus-Status: Clean
Cc: freebsd-fs@freebsd.org
Subject: Re: [ANN] unionfs patchset-14 release
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jun 2006 16:51:36 -0000

At first I looked at fixing the wording for the deprecation of -r
like so:

--- mount_unionfs.c.patchset-14	Fri Jun 16 10:27:35 2006
+++ mount_unionfs.c	Fri Jun 16 10:23:00 2006
@@ -95,8 +95,8 @@
 		switch (ch) {
 		case 'r':
 			errno = EOPNOTSUPP;
-			perror("option '-r' cannot already be used."
-			       "you should use nullfs instead.");
+			perror("Option '-r' is no longer available.  "
+			       "You should use nullfs instead");
 			break;
 		case 'b':
 			iov[iovcnt].iov_base = "below";


But then I thought that it would be even better to just drop it
altogether (and perhaps add a note to UPDATING) like so:

--- mount_unionfs.c.patchset-14	Fri Jun 16 10:27:35 2006
+++ mount_unionfs.c	Fri Jun 16 10:30:41 2006
@@ -91,13 +91,8 @@
 
 	iovcnt = 6;
 	mntflags = 0;
-	while ((ch = getopt(argc, argv, "brc:o:m:M:u:g:")) != -1) {
+	while ((ch = getopt(argc, argv, "bc:o:m:M:u:g:")) != -1) {
 		switch (ch) {
-		case 'r':
-			errno = EOPNOTSUPP;
-			perror("option '-r' cannot already be used."
-			       "you should use nullfs instead.");
-			break;
 		case 'b':
 			iov[iovcnt].iov_base = "below";
 			iov[iovcnt].iov_len = strlen(iov[iovcnt].iov_base) + 1;


Then reword the text in the man page about the deprecation.  It's
wrong anyway since it says -r is available for "backward
compatibility".  To reflect the patchset-14 version accurately, it
should really say that it is ignored.

I would just remove -r from mount_unionfs.c.  Then, in the man page,
perhaps move the discussion about its removal to the HISTORY section
(in addition to some brief words about this rewrite as an evolutionary
milestone).

Thanks for the good work.