Date: Tue, 8 Sep 2015 12:07:10 +0000 (UTC) From: Alexey Dokuchaev <danfe@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r396375 - head/mail/milter-skem Message-ID: <201509081207.t88C7AYS066179@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: danfe Date: Tue Sep 8 12:07:09 2015 New Revision: 396375 URL: https://svnweb.freebsd.org/changeset/ports/396375 Log: getopt() returns `int' according to the standard, but was assigned to `char' variable, and this can break the == -1 check. It works on i386, but not on PowerPC, where `char' is unsigned by default. Use variable of correct type (int) to hold the return value of getopt(3). Modified: head/mail/milter-skem/Makefile Modified: head/mail/milter-skem/Makefile ============================================================================== --- head/mail/milter-skem/Makefile Tue Sep 8 11:57:29 2015 (r396374) +++ head/mail/milter-skem/Makefile Tue Sep 8 12:07:09 2015 (r396375) @@ -30,10 +30,6 @@ OPTIONS_DEFAULT= SKEM_NETINET .include <bsd.port.options.mk> -.if ${ARCH} == "powerpc" -BROKEN= Does not compile on powerpc -.endif - MAKE_ENV+= PTHREAD_LIBS="-lpthread" .for o in ${PORT_OPTIONS:MSKEM_*} @@ -42,4 +38,7 @@ MAKE_ARGS+= -D$o . endif .endfor +post-patch: + @${REINPLACE_CMD} -E 's/char[[:blank:]]+c;/int c;/' ${WRKSRC}/milter.c + .include <bsd.port.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201509081207.t88C7AYS066179>