Date: Fri, 17 Jun 2011 17:59:53 +0000 From: "b. f." <bf1783@googlemail.com> To: Sahil Tandon <sahil@tandon.net> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Sahil Tandon <sahil@freebsd.org>, Wen Heping <wen@freebsd.org>, "cvs-all@freebsd.org" <cvs-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "cvs-ports@freebsd.org" <cvs-ports@freebsd.org> Subject: Re: cvs commit: ports/sysutils/tmux Makefile Message-ID: <BANLkTimHVy6W=Hy4C2J2mLvkXeV4oweopA@mail.gmail.com> In-Reply-To: <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> <BANLkTik344RMoiKtSejSxmEa14WNAR1x4Q@mail.gmail.com> <0C0893AE-B699-4DAB-AD58-C6075349DC2F@tandon.net> <BANLkTinsy9QqgFJ7kBHfMsQ77OnohM0O2w@mail.gmail.com> <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/17/11, Sahil Tandon <sahil@tandon.net> wrote: > On Jun 17, 2011, at 10:43 AM, "b. f." <bf1783@googlemail.com> wrote: > >> On 6/17/11, Sahil Tandon <sahil@tandon.net> wrote: >>> On Jun 16, 2011, at 11:57 PM, "b. f." <bf1783@googlemail.com> wrote: >>> >>>> On 6/17/11, Sahil Tandon <sahil@freebsd.org> wrote: >>>>> On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: >>>>> >>>>>> On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: >>>>>>> wen 2011-06-16 08:42:28 UTC >>>>>>> >>>>>>> Modified files: >>>>>>> sysutils/tmux Makefile >>>>>>> Log: >>>>>>> - Fix build when CFLAGS is set in /etc/make.conf >>>>>> >>>>>> Hmm, default CPPFLAGS is empty. Judging just from the diff, instead >>>>>> of >>>>>> introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which >>>>>> is >>>>>> bogus in the first place: -I is preprocessor flag) should be enough >>>>>> (no >>>>>> MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in >>>>>> this >>>>>> case as well). I am missing something obvious here? >>>>> >>>>> Because of the way upstream Makefile handles CPPFLAGS, it is not so >>>>> straightforward. This was discussed on freebsd-ports: >>>>> >>>>> http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.html >>>>> http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.html >>>> >>>> But this does not seem so different from the many other ports that set >>>> or alter variables in the port Makefile. If a user overrides these >>>> changes in an automatically and recursively-included Makefile like >>>> __MAKE_CONF, or on the command-line, it it the user's problem. Users >>>> should not pollute their port builds by unconditionally defining >>>> variables in __MAKE_CONF, and I don't think that we should add >>>> elaborations to ports to avoid such mistakes. >>> >>> Yes and I think we get that and I personally agree with your sentiment; >>> however, I'm not sure that means maintainers need to revert commits that >>> were done to prevent users from shooting their own foot. >> >> Yes, but the proper anti-foot-shooting measure, is not to make >> sysutils/tmux and the thousands of other ports that may be affected by >> this blunder unnecessarily complicated, but, since we keep running >> into this problem, to add comments to the Handbook and to >> src/share/examples/etc/make.conf, to explain that users should not >> _unconditionally_ define variables that may affect a port build in >> __MAKE_CONF, even CFLAGS, because the file may be automatically >> included several times when make is called recursively, clobbering >> changes made to those variables in Makefiles that are not last in a >> chain of recursions. If we were to follow your argument to it's >> logical conclusion, we would have to remove CPPFLAGS+= and CPPFLAGS= >> statements in every port that uses them and replace them with a >> variable that we think is less likely to be defined in a user's >> __MAKE_CONF, and then manually patch all distfile Makefiles where >> appropriate. The amount of work involved would be enormous, and it >> still wouldn't be completely foolproof. There is no point in putting >> 50 kg. of armor on every user's arms and legs to prevent any user from >> shooting himself, if a number of users are just as likely to direct >> the gun to their unarmored heads. I say keep the choice of variables >> in port Makefiles simple and uniform, and the patching to a minimum. > > I think your passion about this "issue" is sweet. My (incredibly simple) > point is that unless we have a consensus, then going through and reverting > the tmux commit is really not needed. If you strongly believe what you've > gone on about above, so much so as to send related patches for the handbook > and all ports that could be peripherally impacted, that is a commendable > undertaking and I don't think anyone would oppose it. I did not suggest or > even remotely insinuate that anything be changed in ports that directly set > CPPFLAGS so please avoid straw men misrepresentations in your follow-ups. Look, I don't mean to sound overly-exercised about this particular commit -- that's easy to do in email when there is a lack of other verbal and non-verbal cues --- of course it doesn't _need_ to be reverted, although it would be better if it were. Nor did I mean to suggest that in this particular instance you were arguing for sweeping changes. I was merely pointing out the flaws in the reasoning behind the change, and the undesirability of making many such unnecessary ad hoc changes of this kind over time. The real issue (since this problem has come up in multiple PRs, and email and forum threads, I don't enclose it in quotes) is that users (including committers -- the person who filed the original PR behind this change is a src committer, and others have made similar mistakes), are being misled by examples in the base system sources into abuses of __MAKE_CONF, and are breaking port builds. I have previously suggested adding comments to /src/share/examples/etc/make.conf to point out this problem, but no one took up my suggestion, and I can't do it myself because I don't have a src commit bit. I guess that I'll have to try again. b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimHVy6W=Hy4C2J2mLvkXeV4oweopA>