From owner-svn-src-head@freebsd.org Fri Sep 30 18:01:12 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42E05C037E6; Fri, 30 Sep 2016 18:01:12 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD79EBE7; Fri, 30 Sep 2016 18:01:11 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id b80so57436868wme.0; Fri, 30 Sep 2016 11:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PIcS7/d/wdKMVuDtcmaBVCcd92UH9FVPj/h8PF/tukM=; b=QrWH7L0zsVbrQV8qsfTVZGi9loY6WSOO7SOjpo9n+pENHT+mY+DA2p/BokbZv8Stnh 6SktwnZXUZ4N7fGnQ8DWQLC9j4Dp9MBSR/jIYzhRYENGGMCE2e9Fy9jEMQgBX9JTxgxf wQmLzqlqTA96wIbr4cS+nrknhV72b2pvFHyRL1UO9O8+t1Wr9wCizBKMxP30AcsPeKuE HsBKLP5zOQbHRXVzAsciEwIFoI3h/k2S5bMsSBVrZCl8bG9zd65zsFk2DhtWbHDr1nqs XhJ6scTV+mgCrhpXZuHJKvwfAZ5NXzPY/6SU5yyc9HrE4qcdFPFUXoz5Hkx0deHhDfMm MmQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PIcS7/d/wdKMVuDtcmaBVCcd92UH9FVPj/h8PF/tukM=; b=fR1/aYCagUC6wpC0sz4VNZTUgfzsraCvCtE9pGR7MbNHqQEQ+odNlmbkSg+W0DKAK4 tO5DuaOYD4qEuL9SiKxyOaNg5XSvczs7bpPHD+58H6B4KtZmPCYbpAC70R3GxK07eaz1 YC3KPJVlb+8UZylpKaVkmbovIhVpTPA11+XRsMgqH4yKyoQQEIZuOGoKfk0g/FSSpeti 22PVY8FKmvgV8AWwwgG3UkulB1SzOlJaDel6NrmCaw5FoAALhLhBkx/hpv0Zgk9Ea/D1 JqdAaE/+JIa/sKl1qLYgkEfZO7spYNzYLk43px/91Emf3jkivZBy60Y2ILuigFFh0/kX oleg== X-Gm-Message-State: AA6/9RktrZqldgzIrSKysrwyMnlFj/P5rNGecQLTLdjaUug7FGOekR8y5Dk/gIIavqtR0g== X-Received: by 10.28.130.197 with SMTP id e188mr5482994wmd.131.1475258470344; Fri, 30 Sep 2016 11:01:10 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id k206sm5284144wmf.19.2016.09.30.11.01.09 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 30 Sep 2016 11:01:09 -0700 (PDT) Date: Fri, 30 Sep 2016 20:01:07 +0200 From: Mateusz Guzik To: Larry Rosenman Cc: Shawn Webb , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik , owner-svn-src-all@freebsd.org Subject: Re: svn commit: r306509 - in head/sys: fs/nandfs kern sys ufs/ffs Message-ID: <20160930180107.GE3714@dft-labs.eu> References: <201609301711.u8UHB35d046389@repo.freebsd.org> <20160930171845.GA62393@mutt-hardenedbsd> <20160930172845.GC3714@dft-labs.eu> <9eddf030ed57a527c2d23e32289df7cf@thebighonker.lerctr.org> <20160930175540.GD3714@dft-labs.eu> <08ad38dde4ccabe7cf9ee09571c71ca2@thebighonker.lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <08ad38dde4ccabe7cf9ee09571c71ca2@thebighonker.lerctr.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 18:01:12 -0000 On Fri, Sep 30, 2016 at 01:58:16PM -0400, Larry Rosenman wrote: > On 2016-09-30 13:55, Mateusz Guzik wrote: > >On Fri, Sep 30, 2016 at 01:36:26PM -0400, Larry Rosenman wrote: > >>On 2016-09-30 13:28, Mateusz Guzik wrote: > >>>On Fri, Sep 30, 2016 at 01:18:45PM -0400, Shawn Webb wrote: > >>>>On Fri, Sep 30, 2016 at 05:11:03PM +0000, Mateusz Guzik wrote: > >>>>> Author: mjg > >>>>> Date: Fri Sep 30 17:11:03 2016 > >>>>> New Revision: 306509 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/306509 > >>>>> > >>>>> Log: > >>>>> vfs: remove the __bo_vnode field from struct vnode > >>>>> > >>>>> The pointer can be obtained using __containerof instead. > >>>>> > >>>>> Reviewed by: kib > >>>> > >>>>Should __FreeBSD_Version be bumped? > >>>> > >>> > >>>Unlikely. It can be in an odd case it turns out there is a module which > >>>is using the field. > >> > >>Can someone do me a favor and make sure sysutils/lsof still > >>compiles/works? > >> > >>I'm OOT at the moment, and have a test IPv6 patch on my 12 system. > > > >I just ran lsof and it worked fine at least for the basic case. > > > >Apparently it indeed still goes through kernel memory. Did anyone ask > >the author what kind of interfaces would they want to NOT have to do > >this? > > > >Also, it looks like it constains some kind of a loop to imitate > >closefrom. > > > >On truss I see over 3.7 milion (yes, MILION) calls to close. Like this: > >close(3773297) ERR#9 'Bad file > >descriptor' > >close(3773298) ERR#9 'Bad file > >descriptor' > >close(3773299) ERR#9 'Bad file > >descriptor' > >close(3773300) ERR#9 'Bad file > >descriptor' > >close(3773301) ERR#9 'Bad file > >descriptor' > >close(3773302) ERR#9 'Bad file > >descriptor' > >close(3773303) ERR#9 'Bad file > >descriptor' > >[snip] > > > >At least for freebsd this can be patched with the use of closefrom() on > >all supported releases. > > > >Arguably this may be a side effect of limits set too high, perhaps > >linux > >sets them sigifnicanly lower and the problem is not that terrible. > > We've had this discussion before (re: interfaces). I thought the > current versions of lsof only close > the first 1k FD's. (what version of lsof is this? on 12-CURRENT?) > This is 4.90.g,8 "formally" built for 11.0. The typical limit for fd is 1024 on linux, while it is higher on fbsd. I presume it goes up to the limit. (as in, ulimit -n) So what's up with the discussion on interfaces? The current state seems detrimental to everyone. -- Mateusz Guzik