From owner-svn-ports-head@freebsd.org Tue Jul 7 16:13:46 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E8719968CE for ; Tue, 7 Jul 2015 16:13:46 +0000 (UTC) (envelope-from kris@pcbsd.org) Received: from barracuda.ixsystems.com (mail.ixsystems.com [69.198.165.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.ixsystems.com", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E70C91694 for ; Tue, 7 Jul 2015 16:13:45 +0000 (UTC) (envelope-from kris@pcbsd.org) X-ASG-Debug-ID: 1436285622-08ca04286002f40002-7kGxFj Received: from [192.168.0.51] (75-130-56-30.static.kgpt.tn.charter.com [75.130.56.30]) by barracuda.ixsystems.com with ESMTP id HJ0e71OQURR4wNyM (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 07 Jul 2015 09:13:44 -0700 (PDT) X-Barracuda-Envelope-From: kris@pcbsd.org X-Barracuda-AUTH-User: kris@pcbsd.org X-Barracuda-Apparent-Source-IP: 75.130.56.30 X-ASG-Whitelist: Client Message-ID: <559BFAB6.3070107@pcbsd.org> Date: Tue, 07 Jul 2015 12:13:42 -0400 From: Kris Moore User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Adam Weinberger , Kris Moore CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391421 - in head/sysutils: . docker docker/files References: <201507061537.t66FbYeo022971@repo.freebsd.org> <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org> X-ASG-Orig-Subj: Re: svn commit: r391421 - in head/sysutils: . docker docker/files In-Reply-To: <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: 75-130-56-30.static.kgpt.tn.charter.com[75.130.56.30] X-Barracuda-Start-Time: 1436285623 X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256 X-Barracuda-URL: https://10.2.0.41:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ixsystems.com X-Barracuda-BRTS-Status: 1 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 16:13:46 -0000 On 07/07/2015 12:04, Adam Weinberger wrote: > Hi Kris, I hope you don't feel like you're getting picked on for this port. But there are a few unusual/non-optimal things in the Makefile: Oh, no problem. I appreciate the extra eyes on the files. >> +BUILD_DEPENDS= ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \ >> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \ >> + ${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \ >> + sqlite3:${PORTSDIR}/databases/sqlite3 >> +RUN_DEPENDS= ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \ >> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \ >> + sqlite3:${PORTSDIR}/databases/sqlite3 > All of those programs are in ${PATH}. There is no need for the ${LOCALBASE}/bin/ stuff. Done! > Also, git is not used at any point and that dependency can be safely removed, especially given that you already pass DOCKER_GITCOMMIT in env. Thanks for catching that. I was using it at one point, but passing in DOCKER_GITCOMMIT= removes the need for it now. > >> + ${INSTALL} ${WRKSRC}/bundles/latest/binary/docker ${STAGEDIR}${PREFIX}/bin/ > You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}. Done! > # Adam > > -- Kris Moore PC-BSD Software / iXsystems Enterprise Storage & Servers Driven By Open Source