From owner-svn-src-head@FreeBSD.ORG Sat Feb 22 23:28:43 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C40E866; Sat, 22 Feb 2014 23:28:43 +0000 (UTC) Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1F67617E3; Sat, 22 Feb 2014 23:28:41 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id hr17so3826482lab.6 for ; Sat, 22 Feb 2014 15:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=SJA039sWmFl9/veQuFWMZEyR7Pp4FJu1NJ+tfBEJqOo=; b=JBejyudRUF/74gnrcI7VVjwszZxW6dVYkiWp+RFDQj5QwICjIWXRAH2nxrT3GWyxQv jMjgWaoeivSbrDwrFeXo6jaHAiJIq0aKRWrnWTcHUx2H4HNxCjwuLIQD8ApOoLnEjKrx xVylD8VZlktXwrYsETSccS6SPU6CChl+JSXdZonBSrHzG+2QhDZDnN/mIDqhR3Yt5iQ5 2sajlqwbYEGl/Q6TF8TnbwOnrh8memCkl7TT84Elgd7BakYAvlyuZQfxXPgEoWtNZP9g 4NfFeAKRrF+vHKyRUAgtuR0XPwfYafydFOY/+O3u4if8lH6ZGepbaeNW5xOPKVNGRKF6 NJCA== MIME-Version: 1.0 X-Received: by 10.152.143.231 with SMTP id sh7mr8104633lab.26.1393111718918; Sat, 22 Feb 2014 15:28:38 -0800 (PST) Sender: crodr001@gmail.com Received: by 10.112.30.211 with HTTP; Sat, 22 Feb 2014 15:28:38 -0800 (PST) In-Reply-To: <20140219153215.GD63039@FreeBSD.org> References: <201402182217.s1IMHCeM077356@svn.freebsd.org> <20140219101736.GX63039@glebius.int.ru> <20140219140123.Horde.zrXx5GqkiiaAfGIetc98KQ1@mail.vx.sk> <20140219153215.GD63039@FreeBSD.org> Date: Sat, 22 Feb 2014 15:28:38 -0800 X-Google-Sender-Auth: UJQjzTwjm2OAcL6YUrsDjRKonik Message-ID: Subject: Re: svn commit: r262196 - head/sys/netpfil/pf From: Craig Rodrigues To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis , src-committers@freebsd.org, Martin Matuska X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2014 23:28:43 -0000 On Wed, Feb 19, 2014 at 7:32 AM, Gleb Smirnoff wrote: > Third. As you already know, there is projects/pf branch, where Nicos > is getting things right wrt pf+VIMAGE. The patches should first go > to this branch and tested in it. Committing to head (even a good > code), you are creating conflicts for Nicos. You are fixing two > particular problems that hurt you, while Nicos tries to get things > right in general, for everyones sake. My approach on taskqueue > context (that was rejected by Marko), was also an attempt to > create a good and generic way of dealing with the problem. Unfortunately, > Marko didn't suggest good alternatives. > > Gleb, Much thanks to you and Nicos for working on pf + VIMAGE. I work on FreeNAS at iXsystems, and in FreeNAS we enable VIMAGE, because we use jails quiet heavily. I encouraged Martin to go with his patch, because it seemed to solve some problems we had with pf + VIMAGE kernel panics such as this one: https://bugs.freenas.org/issues/4153 Do you have a rough idea when you and Nicos will be ready to merge your projects/pf branch to HEAD? Would you be open to forking the https://github.com/trueos repository on github and putting your pf + VIMAGE patches in there? We could make special builds of FreeNAS and aggressively test your VIMAGE patches. FreeNAS isn't based on FreeBSD CURRENT/FreeBSD 10 yet..... we have some work to do to get up to there. Thanks. -- Craig