From owner-svn-src-head@freebsd.org Fri Jul 29 16:20:09 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72388BA70F0; Fri, 29 Jul 2016 16:20:09 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x22a.google.com (mail-oi0-x22a.google.com [IPv6:2607:f8b0:4003:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 35B6615D1; Fri, 29 Jul 2016 16:20:09 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x22a.google.com with SMTP id l72so112923409oig.2; Fri, 29 Jul 2016 09:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YR/9klZb4TCJFfphROkZaZ0uIeKlWgybqdLZ16q2mA0=; b=ZW8wSPkw6IFhuAOf8BuGLf8AaNz7kQwbdP3+GOMVyWxGJ2QweO0vOhR3z/BAZKZZWf kdpa1ogl35XdMewxCYDbaIfIAOByoJ4lSiiAoWq1ziZcCz0uQA4bhd8kJIdSsKNr+2G4 sqO7rt5VcRlD4E74bljuBcX2S8H/a/UM5DH9Mmzr3KvdI2yw3aHCWTt0NbZHEkO5fZgK n9QLOD8MnA8fVcxJAB3naKWEKs1LWH1Jax74lVBbObFUOY5heBgoWP4ze5i/wH3MAQMX 7mjxFjHvMsFlxDcuxA8VFeIePF3KlrCsGOO80Hayzj+7veb0QhbStvA2AtxB2Dkaitmo 14Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YR/9klZb4TCJFfphROkZaZ0uIeKlWgybqdLZ16q2mA0=; b=KEvzD4T73H+10oLasMxZTC8fLUS6Gk/VsI/UKk2j60xeP38+fVznYdXu9icnXoJu2d Z3QOsJpetuRze1aByg7J5/H3D5myjNVVTF3o+GbFzAloh58Pc7VUWH+glIZA8YgDJq5Z VbLGwu6op39mAl8oT0JNFKjSm0wgkmVWYDJn0Hz0s9n1EYT+VwL+oFEQxl+q4eYdVsDF 1/VsySeboh8EWjBHGT1dT4anbJJY1JcNVrRiRUKERUIlIDQt0DqcWWX1xd+MUqoUjtaE BKrzPEmXkP+aYntDGl5GuwpuEtsHPWItcin1KixW1ko59hhISXmMOB5h7DrPjq/5HxPH aMeg== X-Gm-Message-State: AEkoouvzYtMOVJZ0DtE3VzR7xvJKU9MMCcvsaXHtg0sCl24D1QfQ8+grL76l9Lz2ToN+fOGn1d7RbwHxzon1sg== X-Received: by 10.157.9.248 with SMTP id 53mr26864292otz.35.1469809208296; Fri, 29 Jul 2016 09:20:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.176 with HTTP; Fri, 29 Jul 2016 09:20:07 -0700 (PDT) In-Reply-To: <201607291617.u6TGHsPE060673@repo.freebsd.org> References: <201607291617.u6TGHsPE060673@repo.freebsd.org> From: Benjamin Kaduk Date: Fri, 29 Jul 2016 11:20:07 -0500 Message-ID: Subject: Re: svn commit: r303484 - head/usr.bin/indent To: "Pedro F. Giffuni" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2016 16:20:09 -0000 On Fri, Jul 29, 2016 at 11:17 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Jul 29 16:17:54 2016 > New Revision: 303484 > URL: https://svnweb.freebsd.org/changeset/base/303484 > > Log: > indent(1): Fix breakage caused by single comment following "else". > > indent(1) simply wasn't taught that "else" may be followed by a comment > without any opening brace anywhere on the line, so it was very confused > in such cases. > > Wrong commit message? I see no 'else' in this change. (I guess core's guidance is to revert and recommit with correct message, these days.) -Ben > Differential Revision: https://reviews.freebsd.org/D6966 (Partial) > Obtained from: Piotr Stefaniak > > Modified: > head/usr.bin/indent/indent.c > > Modified: head/usr.bin/indent/indent.c > > ============================================================================== > --- head/usr.bin/indent/indent.c Fri Jul 29 16:14:03 2016 > (r303483) > +++ head/usr.bin/indent/indent.c Fri Jul 29 16:17:54 2016 > (r303484) > @@ -319,6 +319,8 @@ main(int argc, char **argv) > switch (type_code) { > case newline: > ++line_no; > + if (sc_end != NULL) > + goto sw_buffer; /* dump comment, if any */ > flushed_nl = true; > case form_feed: > break; /* form feeds and newlines found here will > be > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >