Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Nov 2016 11:10:55 -0500
From:      "Jason E. Hale" <jhale@freebsd.org>
To:        Dmitry Sivachenko <demon@freebsd.org>
Cc:        Alexey Dokuchaev <danfe@freebsd.org>, ports-committers <ports-committers@freebsd.org>,  "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,  "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r426105 - head/net/haproxy-devel
Message-ID:  <CAJE75NHcggN%2BSK4PbQ=%2BrBC-rsDnqALtprkMqw3P0Q-AcwOgpQ@mail.gmail.com>
In-Reply-To: <20161115002534.GA75384@FreeBSD.org>
References:  <201611141310.uAEDAYJt086157@repo.freebsd.org> <20161115002534.GA75384@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 14, 2016 at 7:25 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Mon, Nov 14, 2016 at 01:10:34PM +0000, Dmitry Sivachenko wrote:
>> New Revision: 426105
>> URL: https://svnweb.freebsd.org/changeset/ports/426105
>>
>> Log:
>>   Force FreeBSD-9 to use OpenSSL from ports because support for
>>   OpenSSL-0.9.x was dropped.
>>
>> [...]
>>  MAKE_ARGS+=  USE_OPENSSL=1
>> +.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1000000
>
> IIUC, transition from 0.9 -> 1.0 occured in r238405, which means OSVERSION
> check should be against 1000015, not 1000000.
>
> https://svnweb.freebsd.org/base?view=revision&revision=238405
>
>> +WITH_OPENSSL_PORT=   yes
>> +.endif
>

Not only that, but WITH_OPENSSL_PORT is deprecated and does not
actually pull in the port version of OpenSSL when used in a port
Makefile.  You should do something like this:

.if ${OSVERSION} < 1000015 && ${SSL_DEFAULT} == base
IGNORE=         requires OpenSSL 1.0.0+. Please use a newer OpenSSL
from ports and set DEFAULT_VERSIONS in /etc/make.conf as appropriate.
.endif

Reason being, the user might be using openssl, openssl-devel,
libressl, or libressl-devel.

-Jason



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NHcggN%2BSK4PbQ=%2BrBC-rsDnqALtprkMqw3P0Q-AcwOgpQ>