From owner-freebsd-current  Fri Nov  8  3: 8:45 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2FBF337B401; Fri,  8 Nov 2002 03:08:44 -0800 (PST)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at [128.130.111.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 01EC843E42; Fri,  8 Nov 2002 03:08:43 -0800 (PST)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from pulcherrima (pulcherrima [128.130.111.23])
	by vexpert.dbai.tuwien.ac.at (8.12.6/8.12.6) with ESMTP id gA8B8XGX015829;
	Fri, 8 Nov 2002 12:08:33 +0100 (CET)
Date: Fri, 8 Nov 2002 12:08:32 +0100 (CET)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Pierre Beyssac <pb@fasterix.frmug.org>
Cc: Dag-Erling Smorgrav <des@ofug.org>,
	Krzysztof J?druczyk <beaker@hot.pl>, <freebsd-current@freebsd.org>,
	Poul-Henning Kamp <phk@freebsd.org>, Alfred Perlstein <bright@mu.org>
Subject: Re: Wine-2002.10.07 port on FreeBSD 5.0-current
In-Reply-To: <20021108103644.GA60686@fasterix.frmug.org>
Message-ID: <Pine.BSF.4.44.0211081156080.42148-100000@pulcherrima.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Fri, 8 Nov 2002, Pierre Beyssac wrote:
>> As for source compatibility, just use the DBREG_DRX macro, which exists
>> in both -STABLE and -CURRENT (it was merged into -STABLE two years ago).
> It's too bad source compatibility hasn't been preserved.

Indeed.

> Argument d is not properly parenthesized, I'll commit the following
> patch if nobody objects:
>
> - #define DBREG_DRX(d,x) (d->dr[(x)]) /* reference dr0 - dr7 by
> -                                          register number */
> + #define DBREG_DRX(d,x) ((d)->dr[(x)]) /* reference dr0 - dr7 by
> +                                          register number */

Alfred committed this very patch last night:

  http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/include/reg.h

> Now for Gerald and Krzysztof, could you try the attached patch? Works
> for me under current at least. I'll test it under stable then I'll send
> it to Wine.

Yes, this looks fine.

Unfortunately (in the sense that both of you duplicated effort),
Alfred independently came up with a similiar patch which went in as
  $PORTSDIR/emulators/wine/files/patch-context_i386
and which I already fed upstream to the Wine folks.

Gerald
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message