Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Aug 2014 10:17:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 192954] [new port] net-im/uTox
Message-ID:  <bug-192954-13-ivm75gsqVU@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-192954-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-192954-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192954

--- Comment #10 from John Marino <marino@FreeBSD.org> ---
Mostly, but 
      @${SETENV} ${MAKE_ENV} DESTDIR=${STAGEDIR} PREFIX=${PREFIX} \ 
     33            ${GMAKE} -C ${WRKSRC} ${INSTALL_TARGET} 
     34     
     35    post-install: 
     36            ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/utox 

^^ that is not good

1) You don't need port-install anymore.  You fixed the stripping problem

2) DO NOT REINVENT THE WHEEL.  MAKE_ARGS is already set with DEST

in fact, why are you doing it his way at all?  move the do-install to
post-install and use the default install target which should work.

3) Please don't have 30 mkdir commands.  You one mkdir command with 30
directory arguments separated by "\" (one directory per line)

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192954-13-ivm75gsqVU>